Skip to content

Commit 3143918

Browse files
committed
Disable susplicious function numeric.T.eig.
This function looks in part like a class (i.e. static method), and in part like an instance method, but neither makes too much sense as it stands. Reported upstream as sloisel/numeric#61 Will disable the method for now, since it is unusable in its current form. Disabling it gets rid of a bunch of closure compiler warnings.
1 parent 3faf4cc commit 3143918

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

src/js/lib/numeric-1.2.6.js

+2
Original file line numberDiff line numberDiff line change
@@ -1338,10 +1338,12 @@ numeric.T.diag = function diag(d) {
13381338
if(y) return new numeric.T(diag(x),diag(y));
13391339
return new numeric.T(diag(x));
13401340
};
1341+
/* // See https://github.com/sloisel/numeric/issues/61
13411342
numeric.T.eig = function eig() {
13421343
if(this.y) { throw new Error('eig: not implemented for complex matrices.'); }
13431344
return numeric.eig(this.x);
13441345
};
1346+
*/
13451347
numeric.T.identity = function identity(n) { return new numeric.T(numeric.identity(n)); };
13461348
numeric.T.prototype.getDiag = function getDiag() {
13471349
var n = numeric;

0 commit comments

Comments
 (0)