Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lwgeom no longer exports st_make_valid #38

Closed
edzer opened this issue Apr 10, 2020 · 1 comment · Fixed by #41
Closed

lwgeom no longer exports st_make_valid #38

edzer opened this issue Apr 10, 2020 · 1 comment · Fixed by #41
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@edzer
Copy link

edzer commented Apr 10, 2020

... but sf does. This will break hereR with e.g.

  > test_check("hereR")
  ── 1. Error: isoline works  ────────────────────────────────────────────────────
  'st_make_valid' is not an exported object from 'namespace:lwgeom'
  Backtrace:
   1. hereR::isoline(poi = poi, aggregate = TRUE)
   2. lwgeom::st_make_valid
   3. base::getExportedValue(pkg, name)

Please fix and resubmit to CRAN to avoid errors in CRAN checks.

@munterfi munterfi self-assigned this Apr 10, 2020
@munterfi munterfi added the dependencies Pull requests that update a dependency file label Apr 10, 2020
@munterfi
Copy link
Owner

Thanks for reporting - fixed and resubmitted to CRAN.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants