fix(core): Ensure that 'workflow-post-execute' event has userId whenever it's available #13326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ver it's available
netroy
force-pushed
the
fix-ADO-3239-userId-on-manual-executions-telemetry
branch
from
3770e67 to
d10bdca
Compare
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
n8n-assistant
bot
added
core
…fecycleHooksForScalingMain
mutdmour
approved these changes
Feb 18, 2025
n8n
|
||||||||||||||||||||||||||||
| Project |
n8n
|
| Branch Review |
fix-ADO-3239-userId-on-manual-executions-telemetry
|
| Run status |
|
| Run duration | 04m 30s |
| Commit |
|
| Committer | कारतोफ्फेलस्क्रिप्ट™ |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
5
|
Skipped
|
0
|
Passing
|
437
|
| View all changes introduced in this branch ↗︎ | |
|
✅ All Cypress E2E specs passed |
netroy
deleted the
fix-ADO-3239-userId-on-manual-executions-telemetry
branch
4 tasks
netroy
added
the
release/backport
Merged
Merged
|
Got released with |
This was referenced Feb 20, 2025
Closed
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In #12816 I accidentally removed
userIdfrom theworkflow-post-executeevent. And due to a lack of tests, this wasn't caught.Related Linear tickets, Github issues, and Community forum posts
ADO-3239
Review / Merge checklist
release/backport(if the PR is an urgent fix that needs to be backported)