Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++ code generation for telemetry packets #632

Open
wants to merge 34 commits into
base: main
Choose a base branch
from

Conversation

bocchino
Copy link
Collaborator

Closes #567.

@bocchino bocchino requested review from Kronos3 and jwest115 February 27, 2025 18:40
Comment on lines +112 to +130
telemetry packets P1 {

packet P1 group 4 {
M.c1.T1
M.c1.T2
M.c1.T3
M.c1.T4
M.c1.T5
M.c1.T6
}

} omit {
M.c2.T1
M.c2.T2
M.c2.T3
M.c2.T4
M.c2.T5
M.c2.T6
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codegen looks good though I am confused about the purpose of omit. This block seems a bit counter-intuitive since it's omiting all the channels it put in the group. Reading https://github.com/nasa/fpp/blob/main/docs/spec/Specifiers/Telemetry-Packet-Set-Specifiers.adoc did not clarify the purpose of omit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement and test C++ code generation for telemetry packets
3 participants