Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Stress Test is not leveraging max threads #1405

Closed
cijothomas opened this issue Nov 27, 2023 · 3 comments · Fixed by #1675
Closed

[Feature]: Stress Test is not leveraging max threads #1405

cijothomas opened this issue Nov 27, 2023 · 3 comments · Fixed by #1675
Assignees
Labels
enhancement New feature or request triage:todo Needs to be traiged.

Comments

@cijothomas
Copy link
Member

Related Problems?

No response

Describe the solution you'd like:

https://github.com/open-telemetry/opentelemetry-rust/blob/main/stress/src/throughput.rs#L73 Shows that it only uses 1 less thread than it should be using, presumably to reserve one thread for the main loop, calculating the stats/displaying on console etc.
Given the main thread would be sleeping almost all the time, wondering if we should use all allowed threads for doing the actual work...

In short, we are not fully pushing the CPU to its max, as I only see CPU utilization around 60-70% when running this. On comparison, similar stress test from https://github.com/open-telemetry/opentelemetry-dotnet/tree/main/test/OpenTelemetry.Tests.Stress.Metrics shows 100% CPU utilization!

Considered Alternatives

No response

Additional Context

No response

@cijothomas cijothomas added enhancement New feature or request triage:todo Needs to be traiged. labels Nov 27, 2023
@cijothomas
Copy link
Member Author

@lzchen Could you see if we can get to push the CPUs to the fullest?

@ThomsonTan
Copy link
Contributor

How are cores in total in your test environment?

I only see CPU utilization around 60-70% when running this

@cijothomas
Copy link
Member Author

How are cores in total in your test environment?

I only see CPU utilization around 60-70% when running this

Tried in laptop with 4 cores and in more powerful machines with 8 cores (16 logical cores). The result is same! We always use 1 less core than available!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request triage:todo Needs to be traiged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants