Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one alias to "oras manifest fetch" #1574

Open
1 task
FeynmanZhou opened this issue Dec 9, 2024 · 5 comments · May be fixed by #1514
Open
1 task

Add one alias to "oras manifest fetch" #1574

FeynmanZhou opened this issue Dec 9, 2024 · 5 comments · May be fixed by #1514
Assignees
Labels
enhancement New feature or request spec required Issues that require specifications
Milestone

Comments

@FeynmanZhou
Copy link
Member

FeynmanZhou commented Dec 9, 2024

What is the version of your ORAS CLI

v1.2.0

What would you like to be added?

oras manifest fetch supports viewing the metadata of a manifest. Literally, fetch might not be very straightforward for the view operation here. Suggest adding one alias oras manifest show to oras manifest fetch for usability.

Why is this needed for ORAS?

Avoid misunderstanding of oras manifest fetch and make the meaning of command more straightforward.

Are you willing to submit PRs to contribute to this feature?

  • Yes, I am willing to implement it.
@FeynmanZhou FeynmanZhou added enhancement New feature or request triage New issues or PRs to be acknowledged by maintainers and removed triage New issues or PRs to be acknowledged by maintainers labels Dec 9, 2024
@FeynmanZhou FeynmanZhou added this to the v1.3.0-beta.2 milestone Dec 9, 2024
@FeynmanZhou FeynmanZhou linked a pull request Dec 9, 2024 that will close this issue
@Wwwsylvia
Copy link
Member

@FeynmanZhou We have manifest get as an alias for manifest fetch. Do we still need oras manifest show and oras manifest inspect?

image

@Wwwsylvia Wwwsylvia added the question Further information is requested label Jan 15, 2025
@shizhMSFT
Copy link
Contributor

inspect is completely a different command and not suitable for being an alias.

@FeynmanZhou FeynmanZhou changed the title Add two alias to "oras manifest fetch" Add one alias to "oras manifest fetch" Feb 13, 2025
@FeynmanZhou
Copy link
Member Author

FeynmanZhou commented Feb 13, 2025

Based on the community meeting discussion and comments above, it makes more sense to add only one alias oras manifest show to oras manifest fetch for usability. I also updated the issue title and description accordingly.

cc @TerryHowe @sajayantony @oras-project/oras-cli

@FeynmanZhou
Copy link
Member Author

The proposed alias has also been added to the multi-arch image management spec: https://github.com/oras-project/oras/pull/1514/files#diff-483519cec3eed7b735884e178105d6d1ee41b60492dc5354dac2ec9c37d8bb19R202

@FeynmanZhou FeynmanZhou linked a pull request Feb 25, 2025 that will close this issue
@FeynmanZhou FeynmanZhou added spec required Issues that require specifications and removed question Further information is requested labels Feb 25, 2025
@Wwwsylvia
Copy link
Member

I'm OK with adding oras manifest show as an additional alias for oras manifest fetch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request spec required Issues that require specifications
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants