Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--verbose flag removed in oras 1.3.0-beta.2 #1640

Open
1 task
flavioschuindt opened this issue Feb 28, 2025 · 4 comments
Open
1 task

--verbose flag removed in oras 1.3.0-beta.2 #1640

flavioschuindt opened this issue Feb 28, 2025 · 4 comments
Labels
bug Something isn't working triage New issues or PRs to be acknowledged by maintainers

Comments

@flavioschuindt
Copy link

What happened in your environment?

The --verbose flag was removed in 1.3.0-beta.2:

Image

In previous versions (e.g. 1.1.0) it used to work:

Image

What did you expect to happen?

--verbose should continue to work in version 1.3.0-beta.2.

How can we reproduce it?

Try to use any subcommand with the --verbose flag.

What is the version of your ORAS CLI?

Version: 1.3.0-beta.2
Go version: go1.24.0
OS/Arch: darwin/amd64
Git commit: 87379d2
Git tree state: clean

What is your OS environment?

Mac OS Sonoma (14.7.2)

Are you willing to submit PRs to fix it?

  • Yes, I am willing to fix it.
@flavioschuindt flavioschuindt added bug Something isn't working triage New issues or PRs to be acknowledged by maintainers labels Feb 28, 2025
@flavioschuindt
Copy link
Author

flavioschuindt commented Feb 28, 2025

Thanks @TerryHowe. Looking at those changes, it seems that the behavior is different across commands. For example, if I try --verbose with oras login, it fails. With oras cp it works with a deprecation statement:

./oras cp --verbose
Flag --verbose has been deprecated, and will be removed in a future release.
Error: "oras cp" requires exactly 2 argument but got 0
Usage: oras cp [flags] <from>{:<tag>|@<digest>} <to>[:<tag>[,<tag>][...]]
Please specify exactly 2 argument as the source and destination for copying. Run "oras cp -h" for more options and examples

Without --verbose for oras login I still get some verbose output:

Image

However, from a consumer perspective I think would be good to maintain the --verbose in ALL commands with the deprecation statement, essentially the behavior of oras cp --verbose and then only in a future release remove it entirely.

@TerryHowe
Copy link
Member

That PR adds a verbose option to some commands like cp

@TerryHowe
Copy link
Member

There was a discussion at the time about the breaking change, but I thought it was worth discussing again since we are still in beta.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working triage New issues or PRs to be acknowledged by maintainers
Projects
None yet
Development

No branches or pull requests

2 participants