Merge pull request #46 from nodaguti/stop-showing-empty-message

Fix an issue where messages without text property are shown as `undefined [plugin-name]`

Author: ai

lib/formatter.js

@@ -10,7 +10,9 @@ module.exports = function(opts) {
   var positionless = options.positionless || 'first';
 
   return function(input) {
-    var messages = input.messages;
+    var messages = input.messages.filter(function(message) {
+      return typeof message.text === 'string';
+    });
     var source = input.source;
 
     if (!messages.length) return '';

test/formatter.js

@@ -256,3 +256,30 @@ test('defaultFormatter with real sourcemaps', function(t) {
   );
   t.end();
 });
+
+var textlessMessages = [
+  {
+    type: 'warning',
+    plugin: 'foo',
+  },
+  {
+    type: 'dependency',
+    plugin: 'bar',
+    file: 'bar file',
+  },
+];
+
+var textlessMessagesOutput = '';
+
+test('defaultFormatter with messages without text property', function(t) {
+  t.equal(
+    stripColor(defaultFormatter({
+      messages: textlessMessages,
+      source: '<input css 1>',
+    })),
+    textlessMessagesOutput,
+    'basic'
+  );
+
+  t.end();
+});