bahncard 100 support?

[grssnbchr]

I guess this is the list of valid loyalty cards that are supported for journeys requests. Is Bahncard 100 not supported?

db-vendo-client/docs/openapi.yaml

Line 387 in 9314e59

- bahncard-2nd-50

[traines-source]

The JS API of db-vendo-client itself should already support BC100, because there you can just use the discount option (haven't verified though). The mapping from the REST API strings to these objects is currently taken from db-rest, which does not contain BC100 yet. But thinking about it, since we are in the process of switching db-rest to db-vendo-client as a backend, it does probably make sense to move this to db-vendo-client itself, in order to avoid having weird circular dependencies. Doing that we can also add BC100 (and the other new/changed loyalty cards that the DB API provides).

[traines-source]

Said and done, I've now moved the db-specific REST param parsing to db-vendo-client and have updated the loyaltyCards, which means that now bahncard-2nd-100, bahncard-1st-100, nl-40, at-klimaticket etc should work. Also, multi-traveller support now works via REST, by passing either multiple ages or multiple loyaltyCards (or both, in corresponding order), e.g.:
/journeys/?from=8000096&to=8700023&loyaltyCard=&loyaltyCard=bahncard-2nd-50&transfers=0
For one traveller without and one with BC50.
I haven't tested very thoroughly whether all the international cards are correctly applied, so lmk if you notice anything :)

Btw, in the DB APIs, there's also this intriguing separate option deutschlandTicketVorhanden, but it doesn't seem to to anything price-wise (and is not used in the DB UI AFAICT).

[grssnbchr]

wow, that was fast :-) will do testing ASAP and provide you with some feedback.