Skip to content

Commit 2639448

Browse files
committed
SNCB/NMBS: document profile as broken πŸ“, skip E2E/integration tests βœ…
related: #284
1 parent c2a71b0 commit 2639448

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

β€Žp/readme.md

+1-1
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ HAFAS endpoint | wrapper library | docs | example code | profile name
1010
-|-|-|-|-
1111
[Deutsche Bahn (DB)](https://en.wikipedia.org/wiki/Deutsche_Bahn) | [`db-hafas`](https://github.com/public-transport/db-hafas) | [docs](db/readme.md) | [example](db/example.js) | [`db`](db)
1212
[Polskie Koleje PaΕ„stwowe (PKP)](https://en.wikipedia.org/wiki/Polish_State_Railways) | [`pkp-hafas`](https://github.com/juliuste/pkp-hafas) | [docs](pkp/readme.md) | [example](pkp/example.js) | [`pkp`](pkp)
13-
[Belgian National Railways (SNCB/NMBS)](https://en.wikipedia.org/wiki/National_Railway_Company_of_Belgium) | - | [docs](sncb/readme.md) | [example](sncb/example.js) | [`sncb`](sncb)
13+
[Belgian National Railways (SNCB/NMBS)](https://en.wikipedia.org/wiki/National_Railway_Company_of_Belgium) | - | [docs](sncb/readme.md) | [example](sncb/example.js) | [`sncb`](sncb) (currently broken)
1414
[*IarnrΓ³d Γ‰ireann* (Irish Rail)](https://en.wikipedia.org/wiki/IarnrΓ³d_Γ‰ireann) | - | [docs](irish-rail/readme.md) | [example](irish-rail/example.js) | [`irish-rail`](irish-rail)
1515
[Berlin & Brandenburg public transport (VBB)](https://en.wikipedia.org/wiki/Verkehrsverbund_Berlin-Brandenburg) | [`vbb-hafas`](https://github.com/public-transport/vbb-hafas) | [docs](vbb/readme.md) | [example](vbb/example.js) | [`vbb`](vbb)
1616
[Berlin public transport (BVG)](https://en.wikipedia.org/wiki/Berliner_Verkehrsbetriebe) | [`bvg-hafas`](https://github.com/public-transport/bvg-hafas) | [docs](bvg/readme.md) | [example](bvg/example.js) | [`bvg`](bvg)

β€Žp/sncb/readme.md

+2
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,7 @@
11
# SNCB profile for `hafas-client`
22

3+
*Note:* **This profile is currently broken** because [SNCB has switched the HAFAS API style](https://github.com/public-transport/hafas-client/issues/284) and we haven't migrated to the new API.
4+
35
[*SociΓ©tΓ© nationale des chemins de fer belges (SNCB)*/*Nationale Maatschappij der Belgische Spoorwegen (NMBS)*](https://en.wikipedia.org/wiki/National_Railway_Company_of_Belgium) is the major public transport provider of [Belgium](https://en.wikipedia.org/wiki/Belgium). This profile adds *SNCB*-specific customizations to `hafas-client`.
46

57
## Usage

β€Žtest/e2e/sncb.js

+5-5
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const gentPaddenhoek = {
3333
latitude: 51.051691, longitude: 3.724914,
3434
}
3535

36-
tap.test('journeys – Gent Sant Pieters to Bruxelles Midi', async (t) => {
36+
tap.skip('journeys – Gent Sant Pieters to Bruxelles Midi', async (t) => {
3737
const res = await client.journeys(gentStPieters, bruxellesMidi, {
3838
results: 4,
3939
departure: when,
@@ -53,7 +53,7 @@ tap.test('journeys – Gent Sant Pieters to Bruxelles Midi', async (t) => {
5353
// todo: via works – with detour
5454
// todo: without detour
5555

56-
tap.test('trip details', async (t) => {
56+
tap.skip('trip details', async (t) => {
5757
const res = await client.journeys(gentStPieters, bruxellesMidi, {
5858
results: 1, departure: when
5959
})
@@ -68,7 +68,7 @@ tap.test('trip details', async (t) => {
6868
t.end()
6969
})
7070

71-
tap.test('arrivals at Bruxelles Midi', async (t) => {
71+
tap.skip('arrivals at Bruxelles Midi', async (t) => {
7272
const res = await client.arrivals(bruxellesMidi, {
7373
duration: 10, when
7474
})
@@ -84,7 +84,7 @@ tap.test('arrivals at Bruxelles Midi', async (t) => {
8484

8585
// todo: nearby
8686

87-
tap.test('radar', async (t) => {
87+
tap.skip('radar', async (t) => {
8888
const res = await client.radar({
8989
north: 51.065,
9090
west: 3.688,
@@ -98,7 +98,7 @@ tap.test('radar', async (t) => {
9898
t.end()
9999
})
100100

101-
tap.test('reachableFrom', async (t) => {
101+
tap.skip('reachableFrom', async (t) => {
102102
await testReachableFrom({
103103
test: t,
104104
reachableFrom: client.reachableFrom,

0 commit comments

Comments
Β (0)