Skip to content

Commit 99b2cf1

Browse files
Codelaxremyleone
authored andcommitted
fix(lbip): remove unused retry in lbip read (scaleway#1314)
lbip read was retrying on 403, meaning it was endless with bad credentials. Errors were wrongly checked too
1 parent 28b2203 commit 99b2cf1

File tree

1 file changed

+4
-17
lines changed

1 file changed

+4
-17
lines changed

scaleway/resource_lb_ip.go

+4-17
Original file line numberDiff line numberDiff line change
@@ -85,23 +85,10 @@ func resourceScalewayLbIPRead(ctx context.Context, d *schema.ResourceData, meta
8585
return diag.FromErr(err)
8686
}
8787

88-
var ip *lbSDK.IP
89-
err = resource.RetryContext(ctx, d.Timeout(schema.TimeoutRead), func() *resource.RetryError {
90-
res, errGet := lbAPI.GetIP(&lbSDK.ZonedAPIGetIPRequest{
91-
Zone: zone,
92-
IPID: ID,
93-
}, scw.WithContext(ctx))
94-
if err != nil {
95-
if is403Error(errGet) {
96-
return resource.RetryableError(errGet)
97-
}
98-
return resource.NonRetryableError(errGet)
99-
}
100-
101-
ip = res
102-
return nil
103-
})
104-
88+
ip, err := lbAPI.GetIP(&lbSDK.ZonedAPIGetIPRequest{
89+
Zone: zone,
90+
IPID: ID,
91+
}, scw.WithContext(ctx))
10592
if err != nil {
10693
if is404Error(err) {
10794
d.SetId("")

0 commit comments

Comments
 (0)