Skip to content

Commit a4ee187

Browse files
authored
[#1634] Replace cdn links to import from node_modules instead (#1710)
Some css files are currently imported directly in the code, making it difficult to manage. Let us import from node_module for easy management.
1 parent fb0afca commit a4ee187

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

frontend/package.json

+3
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,7 @@
2626
},
2727
"homepage": "https://github.com/reposense/RepoSense#readme",
2828
"dependencies": {
29+
"@fontsource/titillium-web": "^4.5.3",
2930
"@fortawesome/fontawesome-svg-core": "^1.3.0",
3031
"@fortawesome/free-brands-svg-icons": "^6.0.0",
3132
"@fortawesome/free-solid-svg-icons": "^6.0.0",
@@ -34,6 +35,8 @@
3435
"highlight.js": "^10.5.0",
3536
"jszip": "^3.5.0",
3637
"minimatch": "^3.0.4",
38+
"muicss": "^0.10.3",
39+
"normalize.css": "^8.0.1",
3740
"pug-lint-vue": "^0.4.0",
3841
"seedrandom": "^3.0.5",
3942
"vue": "^3.2.31",

frontend/src/app.vue

-6
Original file line numberDiff line numberDiff line change
@@ -319,12 +319,6 @@ export default app;
319319

320320

321321
<style lang="scss">
322-
@import 'https://fonts.googleapis.com/css?family=Titillium+Web';
323-
@import 'https://cdn.jsdelivr.net/npm/[email protected]/normalize.min.css';
324-
@import 'https://cdn.jsdelivr.net/npm/[email protected]/dist/css/mui.min.css';
325-
@import 'https://cdn.jsdelivr.net/npm/[email protected]/styles/color-brewer.min.css';
326-
@import 'https://cdn.jsdelivr.net/npm/vue-loading-overlay@5/dist/vue-loading.css';
327-
328322
@import './styles/style.scss';
329323
@import './styles/panels.scss';
330324
</style>

frontend/src/main.js

+5
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@ import { createApp } from 'vue';
22
import { dom } from '@fortawesome/fontawesome-svg-core';
33
import { FontAwesomeIcon } from '@fortawesome/vue-fontawesome';
44
import hljs from 'highlight.js';
5+
import 'muicss/dist/css/mui.min.css';
6+
import 'normalize.css/normalize.css';
7+
import 'vue-loading-overlay/dist/vue-loading.css';
8+
import 'highlight.js/styles/color-brewer.css';
9+
import '@fontsource/titillium-web';
510

611
// Need to import for side effects
712
import './utils/api';

0 commit comments

Comments
 (0)