[#2283] Display time periods for each repository #2303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Airiinnn
force-pushed
the
2283-fe-display-individual-time-periods
branch
from
49ce107 to
985cdb8
Compare
|
On hold. Waiting for backend changes to be merged to add the cypress tests |
|
@Airiinnn For UI changes, also give before-and-after screenshots in the PR. |
CYX22222003
reviewed
Mar 10, 2025
| @@ -785,7 +798,7 @@ export default defineComponent({ | |||
| const regexToRemoveWidget = /([?&])((chartIndex|chartGroupIndex)=\d+)/g; | |||
| return url.replace(regexToRemoveWidget, ''); | |||
| }, | |||
| getRepo(repo: Array<Repo>): Array<Repo> { | |||
| getRepo(repo: Array<User>): Array<User> { | |||
There was a problem hiding this comment.
Is there any particular reason to change the typing here?
There was a problem hiding this comment.
Yes, following the call stack, the previous Repo type was wrong and should be User instead.
Naming was very confusing to begin with, maybe we can fix this in another PR for refactoring and cleanup. I'm worried changing parts of it now may make it even more confusing.
There was a problem hiding this comment.
I see, maybe we should create another PR to handle this issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2283
Proposed commit message
Other information
Changes:
summary.jsonand filter range). Refer to last summary chart in screenshot to see intended behavior.Old:
Previously, date indicators are only visible when "trim timeline" is enabled.
New: