Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removal of test mode flag in reposense code #1941

Open
chan-j-d opened this issue Mar 12, 2023 · 2 comments · May be fixed by nseah21/RepoSense#2 or #2314
Open

Removal of test mode flag in reposense code #1941

chan-j-d opened this issue Mar 12, 2023 · 2 comments · May be fixed by nseah21/RepoSense#2 or #2314
Assignees
@lyuanww
Labels
a-Backend a-CLI d.FirstTimers

Comments

@chan-j-d
Copy link
Contributor

With PR #1911 that removes the only use of the test mode flag in reposense, I think we can consider removing it to avoid additional maintenance. The original test mode flag was introduced in this PR #1816 where it was necessary since it was not known that the system tests were not quite functioning properly.

The test mode flag is primarily used for implementing some test specific behavior in a reposense run which is currently not required. As such, I would like to put forward the suggestion that we remove related code and documentation for the test mode flag.
@sikai00 sikai00 mentioned this issue Apr 5, 2023
Closed
@sikai00
Copy link
Member

sikai00 commented Apr 19, 2023

I was initially hesitant on removing the test mode flag because the parallelization of system test in #1900 may require the flag. However given that the #1900 will not be merged, I believe it will be good to remove the test mode behavior. Currently I think it is only used to decide if the fresh cloning flag should be active or not. I believe it will be fine to have the fresh cloning flag as a standalone flag that does not require the test mode flag.

I think this would be a good first timer issue, as it mainly only involves removal of code related to test mode. What do you think?

@chan-j-d
Copy link
Contributor Author

Sounds good to me @sikai00

@nseah21 nseah21 linked a pull request Jun 15, 2023 that will close this issue
Open
@lyuanww lyuanww self-assigned this Feb 26, 2025
@lyuanww lyuanww linked a pull request Mar 3, 2025 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lyuanww lyuanww

Labels
a-Backend a-CLI d.FirstTimers
Projects
RepoSense Roadmap
Status: No status
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update cli flags nseah21/RepoSense
[#1941] Remove test mode flag lyuanww/RepoSense
3 participants
@sikai00 @chan-j-d @lyuanww