Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[interpreter] Always build LLVM with C++17 #17735

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[interpreter] Always build LLVM with C++17 #17735

wants to merge 2 commits into from

Conversation

hahnjo
Copy link
Member

@hahnjo hahnjo commented Feb 17, 2025

Closes #17686

hahnjo and others added 2 commits February 17, 2025 10:09
@hahnjo
[llvm-project][Support] Ensure complete type DelimitedScope
caeaaed 
JSONScopedPrinter has a std::unique_ptr<DelimitedScope> member and
defaulted constructor argument, so it needs a complete type. This
resolves one of the many build errors with C++23 using Clang.

Backport of llvm/llvm-project#127459
TODO: needs a tag
@hahnjo
[interpreter] Always build LLVM with C++17
2287241 
Closes root-project#17686
@hahnjo hahnjo added in:Build System in:Cling clean build Ask CI to do non-incremental build on PR labels Feb 17, 2025
@hahnjo hahnjo self-assigned this Feb 17, 2025
@hahnjo hahnjo mentioned this pull request Feb 17, 2025
Open
1 task
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 17, 2025 •
edited
Loading

Test Results

    18 files      18 suites   4d 3h 8m 14s ⏱️
 2 722 tests  2 722 ✅ 0 💤 0 ❌
47 294 runs  47 294 ✅ 0 💤 0 ❌

Results for commit 2287241.

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vgvassilev vgvassilev Awaiting requested review from vgvassilev vgvassilev is a code owner

@dpiparo dpiparo Awaiting requested review from dpiparo

@devajithvs devajithvs Awaiting requested review from devajithvs

@bellenot bellenot Awaiting requested review from bellenot bellenot will be requested when the pull request is marked ready for review bellenot is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@hahnjo hahnjo

Labels
clean build Ask CI to do non-incremental build on PR in:Build System in:Cling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

C++23 crash in DiagnosticInfo.h
1 participant
@hahnjo