Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(journey-maps): add extrusion layer #2448

Merged
merged 35 commits into from
Dec 5, 2024
Merged

feat(journey-maps): add extrusion layer #2448

merged 35 commits into from
Dec 5, 2024

Conversation

swiss-chris
Copy link
Contributor

No description provided.

@swiss-chris
feat(journey-maps): enable map rotation and pitch
dfe13be 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
87c1bad 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
3f0231d 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
363482b 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
4db2f0d 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
7c2cfb7 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
0490426 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
99c06ce 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
2cfe589 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
3c2916e 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
653a0c6 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
6d92f99 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
0aa44ac 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
8997a08 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): fix compass icon bearing updates for Web Component
599d8be 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): fix compass icon bearing updates for Web Component
6834547 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
8564ca4 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
1c334df 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): enable map rotation and pitch
5c4a165 
Refs: ROKAS-2162
@swiss-chris
Merge remote-tracking branch 'origin/main' into feature/cdi/ROKAS-216…
2b63dde 
…2-enable-rotate-and-pitch
@swiss-chris
feat(journey-maps): fix for hiding compass icon
d7036f1 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): cleanup
814a3ff 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): fix normalized diff
bff0375 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): use normalized bearing value < 360
f08ea75 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): also handle pitch with the compass button
018918f 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): also handle pitch with the compass button
ef0b4dd 
Refs: ROKAS-2162
@swiss-chris
feat(journey-maps): add extrusions to buildings
8e4ce3e 
Refs: ROKAS-2163
@swiss-chris swiss-chris changed the base branch from main to feature/cdi/ROKAS-2162-enable-rotate-and-pitch December 3, 2024 16:00
@github-actions github-actions bot temporarily deployed to preview-pr2448 December 3, 2024 16:19 Inactive
@swiss-chris swiss-chris changed the title cdi, ROKAS-2163 add extrusion layer feat(journey-maps): add extrusion layer Dec 4, 2024
@github-actions github-actions bot requested a deployment to preview-pr2448 December 4, 2024 11:14 In progress
@github-actions github-actions bot requested a deployment to preview-pr2448 December 4, 2024 15:00 In progress
@github-actions github-actions bot requested a deployment to preview-pr2448 December 4, 2024 15:47 In progress
@swiss-chris swiss-chris marked this pull request as ready for review December 4, 2024 15:58
@github-actions github-actions bot requested a deployment to preview-pr2448 December 4, 2024 16:15 In progress
@swiss-chris swiss-chris marked this pull request as draft December 4, 2024 16:16
Base automatically changed from feature/cdi/ROKAS-2162-enable-rotate-and-pitch to main December 4, 2024 17:05
andrinsibold
andrinsibold reviewed Dec 5, 2024
View reviewed changes
Copy link
Contributor

@andrinsibold andrinsibold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small change but rest LGTM

andrinsibold
andrinsibold approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@andrinsibold andrinsibold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@swiss-chris
Merge remote-tracking branch 'origin/main' into feature/cdi/ROKAS-216…
05ab9cc 
…3-add-extrusion-layer

# Conflicts:
#	src/components-examples/journey-maps/angular/journey-maps-map-navigation/journey-maps-map-navigation-example.html
#	src/components-examples/journey-maps/angular/journey-maps-map-navigation/journey-maps-map-navigation-example.ts
#	src/journey-maps/angular/journey-maps.interfaces.ts
#	src/journey-maps/web-component/showcase.ts
@swiss-chris swiss-chris marked this pull request as ready for review December 5, 2024 10:17
@mhaertwig mhaertwig merged commit a6089e6 into main Dec 5, 2024
18 checks passed
@mhaertwig mhaertwig deleted the feature/cdi/ROKAS-2163-add-extrusion-layer branch December 5, 2024 11:49
sbb-design-systems-bot bot pushed a commit that referenced this pull request Dec 5, 2024
@swiss-chris
feat(journey-maps): add extrusion layer (#2448)
6553151
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhaertwig mhaertwig mhaertwig approved these changes

@andrinsibold andrinsibold andrinsibold approved these changes

@davidkuehner davidkuehner Awaiting requested review from davidkuehner

@mstankala mstankala Awaiting requested review from mstankala mstankala is a code owner

@kyubisation kyubisation Awaiting requested review from kyubisation kyubisation is a code owner

@jeripeierSBB jeripeierSBB Awaiting requested review from jeripeierSBB jeripeierSBB is a code owner

Assignees
No one assigned
Labels
preview-available target: 19.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@swiss-chris @mhaertwig @andrinsibold