Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular/select): add opt-in input that allows selection of nullable options #2466

Merged
merged 1 commit into from
Jan 7, 2025

Conversation

mhaertwig
Copy link
Collaborator

By default, sbb-select treats options with nullable values as "reset options", meaning that they can't be selected, but rather they clear the select's value. This behavior is based on how the native select works, however in some cases it's not desirable. These changes add an input that users can use to opt out of the default behavior.

…le options

By default, `sbb-select` treats options with nullable values as "reset options", meaning that they can't be selected, but rather they clear the select's value. This behavior is based on how the native `select` works, however in some cases it's not desirable. These changes add an input that users can use to opt out of the default behavior.
Copy link
Collaborator

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mhaertwig mhaertwig merged commit aa67bec into main Jan 7, 2025
20 checks passed
@mhaertwig mhaertwig deleted the feature/select branch January 7, 2025 09:03
sbb-design-systems-bot bot pushed a commit that referenced this pull request Jan 7, 2025
…le options (#2466)

By default, `sbb-select` treats options with nullable values as "reset options", meaning that they can't be selected, but rather they clear the select's value. This behavior is based on how the native `select` works, however in some cases it's not desirable. These changes add an input that users can use to opt out of the default behavior.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants