feat(rdb): add support for acl rules (#784)

Co-authored-by: Jean-Sébastien Hedde <[email protected]>

Author: remyleone

docs/data-sources/rdb_acl.md

@@ -0,0 +1,34 @@
+---
+layout: "scaleway"
+page_title: "Scaleway: scaleway_rdb_acl"
+description: |-
+  Gets information about the RDB instance network Access Control List.
+---
+
+# scaleway_rdb_acl
+
+Gets information about the RDB instance network Access Control List.
+
+## Example Usage
+
+```hcl
+# Get the database ACL for the instanceid 11111111-1111-1111-1111-111111111111 located in fr-par
+data "scaleway_rdb_acl" "my_acl" {
+  instance_id = "fr-par/11111111-1111-1111-1111-111111111111"
+}
+```
+
+## Argument Reference
+
+- `instance_id` - (Required) The RDB instance ID.
+
+## Attribute Reference
+
+In addition to all above arguments, the following attributes are exported:
+
+- `acl_rules` - A list of ACLs (structure is described below)
+
+The `acl_rules` block supports:
+
+- `ip` - The ip range to whitelist in [CIDR notation](https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing#CIDR_notation)
+- `description` - A simple text describing this rule

docs/resources/rdb_acl.md

@@ -0,0 +1,53 @@
+---
+page_title: "Scaleway: scaleway_rdb_acl"
+description: |-
+  Manages Scaleway Database Instances.
+---
+
+# scaleway_rdb_acl
+
+Creates and manages Scaleway Database instance autorized IPs.
+For more information, see [the documentation](https://developers.scaleway.com/en/products/rdb/api).
+
+## Examples
+
+### Basic
+
+```hcl
+resource scaleway_rdb_acl main {
+  instance_id = scaleway_rdb_instance.main.id
+  acl_rules {
+    ip = "1.2.3.4/32"
+    description = "foo"
+  }
+}
+```
+
+## Arguments Reference
+
+The following arguments are supported:
+
+- `instance_id` - (Required) The instance on which to create the ACL.
+
+~> **Important:** Updates to `instance_id` will recreate the Database ACL.
+
+- `acl_rules` - A list of ACLs (structure is described below)
+
+The `acl_rules` block supports:
+
+- `ip` - (Required) The ip range to whitelist in [CIDR notation](https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing#CIDR_notation)
+- `description` - (Optional) A simple text describing this rule
+
+
+## Attributes Reference
+
+All arguments above are exported.
+
+## Import
+
+Database Instance can be imported using the `{region}/{id}`, e.g.
+
+```bash
+$ terraform import scaleway_rdb_acl.acl01 fr-par/11111111-1111-1111-1111-111111111111
+```
+

scaleway/data_source_rdb_acl.go

@@ -0,0 +1,42 @@
+package scaleway
+
+import (
+	"context"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+)
+
+func dataSourceScalewayRDBACL() *schema.Resource {
+	// Generate datasource schema from resource
+	dsSchema := datasourceSchemaFromResourceSchema(resourceScalewayRdbACL().Schema)
+
+	dsSchema["instance_id"].Computed = false
+	dsSchema["instance_id"].Required = true
+
+	return &schema.Resource{
+		ReadContext: dataSourceScalewayRDBACLRead,
+		Schema:      dsSchema,
+	}
+}
+
+func dataSourceScalewayRDBACLRead(ctx context.Context, d *schema.ResourceData, meta interface{}) diag.Diagnostics {
+	_, region, err := rdbAPIWithRegion(d, meta)
+	if err != nil {
+		return diag.FromErr(err)
+	}
+	instanceID, _ := d.GetOk("instance_id")
+
+	_, _, err = parseLocalizedID(instanceID.(string))
+	regionalID := instanceID
+	if err != nil {
+		regionalID = datasourceNewRegionalizedID(instanceID, region)
+	}
+
+	d.SetId(regionalID.(string))
+	err = d.Set("instance_id", regionalID)
+	if err != nil {
+		return diag.FromErr(err)
+	}
+	return resourceScalewayRdbACLRead(ctx, d, meta)
+}

scaleway/data_source_rdb_acl_test.go

@@ -0,0 +1,77 @@
+package scaleway
+
+import (
+	"fmt"
+	"testing"
+
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
+)
+
+func TestAccScalewayDataSourceRDBAcl_Basic(t *testing.T) {
+	tt := NewTestTools(t)
+	defer tt.Cleanup()
+	instanceName := "TestAccScalewayDataSourceRDBAcl_Basic"
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: tt.ProviderFactories,
+		CheckDestroy:      testAccCheckScalewayRdbInstanceDestroy(tt),
+		Steps: []resource.TestStep{
+			{
+				Config: fmt.Sprintf(`
+					resource "scaleway_rdb_instance" "main" {
+						name = "%s"
+						node_type = "db-dev-s"
+						engine = "PostgreSQL-12"
+						is_ha_cluster = false
+					}
+
+					resource "scaleway_rdb_acl" "main" {
+						instance_id = scaleway_rdb_instance.main.id
+						acl_rules {
+							ip = "1.2.3.4/32"
+							description = "foo"
+						}
+
+						acl_rules {
+							ip = "4.5.6.7/32"
+							description = "bar"
+						}
+					}
+					`, instanceName),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("scaleway_rdb_acl.main", "acl_rules.0.ip", "1.2.3.4/32"),
+				),
+			},
+			{
+				Config: fmt.Sprintf(`
+					resource "scaleway_rdb_instance" "main" {
+						name = "%s"
+						node_type = "db-dev-s"
+						engine = "PostgreSQL-12"
+						is_ha_cluster = false
+					}
+
+					resource "scaleway_rdb_acl" "main" {
+						instance_id = scaleway_rdb_instance.main.id
+						acl_rules {
+							ip = "1.2.3.4/32"
+							description = "foo"
+						}
+
+						acl_rules {
+							ip = "4.5.6.7/32"
+							description = "bar"
+						}
+					}
+					data "scaleway_rdb_acl" "maindata" {
+						instance_id = scaleway_rdb_instance.main.id
+
+					}`, instanceName),
+				Check: resource.ComposeTestCheckFunc(
+					resource.TestCheckResourceAttr("scaleway_rdb_acl.main", "acl_rules.0.ip", "1.2.3.4/32"),
+					resource.TestCheckResourceAttr("data.scaleway_rdb_acl.maindata", "acl_rules.0.ip", "1.2.3.4/32"),
+				),
+			},
+		},
+	})
+}

scaleway/provider.go

@@ -79,6 +79,7 @@ func Provider(config *ProviderConfig) plugin.ProviderFunc {
 				"scaleway_lb_certificate":                resourceScalewayLbCertificate(),
 				"scaleway_lb_frontend":                   resourceScalewayLbFrontend(),
 				"scaleway_registry_namespace":            resourceScalewayRegistryNamespace(),
+				"scaleway_rdb_acl":                       resourceScalewayRdbACL(),
 				"scaleway_rdb_database":                  resourceScalewayRdbDatabase(),
 				"scaleway_rdb_instance":                  resourceScalewayRdbInstance(),
 				"scaleway_rdb_user":                      resourceScalewayRdbUser(),
@@ -93,6 +94,7 @@ func Provider(config *ProviderConfig) plugin.ProviderFunc {
 				"scaleway_instance_image":          dataSourceScalewayInstanceImage(),
 				"scaleway_instance_volume":         dataSourceScalewayInstanceVolume(),
 				"scaleway_baremetal_offer":         dataSourceScalewayBaremetalOffer(),
+				"scaleway_rdb_acl":                 dataSourceScalewayRDBACL(),
 				"scaleway_rdb_instance":            dataSourceScalewayRDBInstance(),
 				"scaleway_rdb_database":            dataSourceScalewayRDBDatabase(),
 				"scaleway_k8s_cluster":             dataSourceScalewayK8SCluster(),