feat(apple-silicon): add documentation and missing types (#1088)

Author: Monitob

docs/resources/apple_silicon.md

@@ -0,0 +1,58 @@
+---
+page_title: "Scaleway: scaleway_apple_silicon"
+description: |- Manages Scaleway Apple silicon M1 as-a-Service.
+---
+
+# scaleway_apple_silicon
+
+Creates and manages Scaleway Apple silicon M1. For more information,
+see [the documentation](https://www.scaleway.com/en/docs/compute/apple-silicon/concepts).
+
+## Examples
+
+### Basic
+
+```hcl
+resource scaleway_apple_silicon_server server {
+    name = "test-m1"
+    type = "M1-M"
+}
+```
+
+## Arguments Reference
+
+The following arguments are supported:
+
+- `type` - (Required) The commercial type of the server. You find all the available types on
+  the [pricing page](https://www.scaleway.com/en/pricing/#apple-silicon). Updates to this field will recreate a new
+  resource.
+
+- `name` - (Optional) The name of the server.
+
+- `zone` - (Defaults to [provider](../index.md#zone) `zone`) The [zone](../guides/regions_and_zones.md#zones) in which
+  the server should be created.
+
+- `project_id` - (Defaults to [provider](../index.md#project_id) `project_id`) The ID of the project the server is
+  associated with.
+
+## Attributes Reference
+
+In addition to all above arguments, the following attributes are exported:
+
+- `id` - The ID of the server.
+- `state` - The state of the server. Check the possible values on
+  our [sdk](https://github.com/scaleway/scaleway-sdk-go/blob/master/api/applesilicon/v1alpha1/applesilicon_sdk.go#L103).
+- `ip` - IPv4 address of the server (IPv4 address).
+- `vnc_url` - URL of the VNC.
+- `created_at` - The date and time of the creation of the Apple Silicon server.
+- `updated_at` - The date and time of the last update of the Apple Silicon server.
+- `deleted_at` - The minimal date and time on which you can delete this server due to Apple licence.
+- `organization_id` - The organization ID the server is associated with.
+
+## Import
+
+Instance servers can be imported using the `{zone}/{id}`, e.g.
+
+```bash
+$ terraform import scaleway_apple_silicon.server fr-par-1/11111111-1111-1111-1111-111111111111
+```

scaleway/helpers_apple_silicon.go

@@ -12,6 +12,10 @@ const (
 	defaultAppleSiliconServerTimeout = 2 * time.Minute
 )
 
+const (
+	AppleSiliconM1Type = "M1-M"
+)
+
 // asAPIWithZone returns a new apple silicon API and the zone
 func asAPIWithZone(d *schema.ResourceData, m interface{}) (*applesilicon.API, scw.Zone, error) {
 	meta := m.(*Meta)

scaleway/resource_apple_silicon_server.go

@@ -6,6 +6,7 @@ import (
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 	applesilicon "github.com/scaleway/scaleway-sdk-go/api/applesilicon/v1alpha1"
 	"github.com/scaleway/scaleway-sdk-go/scw"
 )
@@ -35,8 +36,9 @@ func resourceScalewayAppleSiliconServer() *schema.Resource {
 				Description: "Type of the server",
 				Required:    true,
 				ForceNew:    true,
+				ValidateFunc: validation.StringInSlice([]string{
+					AppleSiliconM1Type}, false),
 			},
-
 			// Computed
 			"ip": {
 				Type:        schema.TypeString,
@@ -48,7 +50,11 @@ func resourceScalewayAppleSiliconServer() *schema.Resource {
 				Description: "VNC url use to connect remotely to the desktop GUI",
 				Computed:    true,
 			},
-
+			"state": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "The state of the server",
+			},
 			"created_at": {
 				Type:        schema.TypeString,
 				Computed:    true,
@@ -124,6 +130,7 @@ func resourceScalewayAppleSiliconServerRead(ctx context.Context, d *schema.Resou
 
 	_ = d.Set("name", res.Name)
 	_ = d.Set("type", res.Type)
+	_ = d.Set("state", res.Status.String())
 	_ = d.Set("created_at", res.CreatedAt.Format(time.RFC3339))
 	_ = d.Set("updated_at", res.UpdatedAt.Format(time.RFC3339))
 	_ = d.Set("deletable_at", res.DeletableAt.Format(time.RFC3339))

scaleway/resource_apple_silicon_server_test.go

@@ -59,7 +59,7 @@ func TestAccScalewayAppleSiliconServer_Basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					testAccCheckScalewayAppleSiliconExists(tt, "scaleway_apple_silicon_server.main"),
 					resource.TestCheckResourceAttr("scaleway_apple_silicon_server.main", "name", "test-m1"),
-					resource.TestCheckResourceAttr("scaleway_apple_silicon_server.main", "type", "M1-M"),
+					resource.TestCheckResourceAttr("scaleway_apple_silicon_server.main", "type", AppleSiliconM1Type),
 					// Computed
 					resource.TestCheckResourceAttrSet("scaleway_apple_silicon_server.main", "ip"),
 					resource.TestCheckResourceAttrSet("scaleway_apple_silicon_server.main", "vnc_url"),