fix(domain-record): set name as optional (#1155)

Author: Monitob

docs/resources/domain_record.md

@@ -188,7 +188,7 @@ The following arguments are supported:
 
 - `keep_empty_zone` - (Optional, default: `false`) When destroying a resource, if only NS records remain and this is set to `false`, the zone will be deleted. Please note, each zone not deleted will [cost you money](https://www.scaleway.com/en/dns/)
 
-- `name` - (Required) The name of the record (can be an empty string for a root record).
+- `name` - (Optional) The name of the record (can be an empty string for a root record).
 
 - `type` - (Required) The type of the record (`A`, `AAAA`, `MX`, `CNAME`, `ALIAS`, `NS`, `PTR`, `SRV`, `TXT`, `TLSA`, or `CAA`).
 

scaleway/resource_domain_record.go

@@ -47,7 +47,7 @@ func resourceScalewayDomainRecord() *schema.Resource {
 				Type:        schema.TypeString,
 				Description: "The name of the record",
 				ForceNew:    true,
-				Required:    true,
+				Optional:    true,
 			},
 			"type": {
 				Type:        schema.TypeString,

scaleway/resource_domain_record_test.go

@@ -72,6 +72,27 @@ func TestAccScalewayDomainRecord_Basic(t *testing.T) {
 		ProviderFactories: tt.ProviderFactories,
 		CheckDestroy:      testAccCheckScalewayDomainRecordDestroy(tt),
 		Steps: []resource.TestStep{
+			{
+				Config: fmt.Sprintf(`
+					resource "scaleway_domain_record" "tf_A" {
+						dns_zone = "%s"
+						type     = "%s"
+						data     = "%s"
+						ttl      = %d
+						priority = %d
+					}
+				`, testDNSZone, recordType, data, ttl, priority),
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckScalewayDomainRecordExists(tt, "scaleway_domain_record.tf_A"),
+					resource.TestCheckResourceAttr("scaleway_domain_record.tf_A", "dns_zone", testDNSZone),
+					resource.TestCheckResourceAttr("scaleway_domain_record.tf_A", "name", ""),
+					resource.TestCheckResourceAttr("scaleway_domain_record.tf_A", "type", recordType),
+					resource.TestCheckResourceAttr("scaleway_domain_record.tf_A", "data", data),
+					resource.TestCheckResourceAttr("scaleway_domain_record.tf_A", "ttl", fmt.Sprint(ttl)),
+					resource.TestCheckResourceAttr("scaleway_domain_record.tf_A", "priority", fmt.Sprint(priority)),
+					testCheckResourceAttrUUID("scaleway_domain_record.tf_A", "id"),
+				),
+			},
 			{
 				Config: fmt.Sprintf(`
 					resource "scaleway_domain_record" "tf_A" {