chore: add support for unused (#2716)

Author: remyleone

.golangci.yml

@@ -67,6 +67,7 @@ linters:
     - tparallel # tparallel detects inappropriate usage of t.Parallel() method in your Go test codes [fast: false, auto-fix: false]
     - typecheck # Like the front-end of a Go compiler, parses and type-checks Go code [fast: false, auto-fix: false]
     - unconvert # Remove unnecessary type conversions [fast: false, auto-fix: false]
+    - unused #(megacheck): Checks Go code for unused constants, variables, functions and types [fast: false, auto-fix: false]
     - usestdlibvars # A linter that detect the possibility to use variables/constants from the Go standard library. [fast: true, auto-fix: false]
     - wastedassign # wastedassign finds wasted assignment statements. [fast: false, auto-fix: false]
     - whitespace # Tool for detection of leading and trailing whitespace [fast: true, auto-fix: true]
@@ -94,7 +95,6 @@ linters:
     - nilnil # Checks that there is no simultaneous return of `nil` error and an invalid value. [fast: false, auto-fix: false]
     - nlreturn # nlreturn checks for a new line before return and branch statements to increase code clarity [fast: true, auto-fix: false]
     - staticcheck #(megacheck): Staticcheck is a go vet on steroids, applying a ton of static analysis checks [fast: false, auto-fix: false]
-    - unused #(megacheck): Checks Go code for unused constants, variables, functions and types [fast: false, auto-fix: false]
     - varnamelen # checks that the length of a variable's name matches its scope [fast: false, auto-fix: false]
     - wsl # Whitespace Linter - Forces you to use empty lines! [fast: true, auto-fix: false]
 

internal/services/iam/ssh_key.go

@@ -192,11 +192,3 @@ func resourceIamSSKKeyDelete(ctx context.Context, d *schema.ResourceData, m inte
 
 	return nil
 }
-
-func removePublicSSHKeyComment(publicKey string) string {
-	parts := strings.Split(publicKey, " ")
-	if len(parts) == 3 {
-		return strings.Join(parts[:2], " ")
-	}
-	return publicKey
-}

internal/services/instance/helpers_instance_block_test.go

@@ -10,16 +10,6 @@ import (
 )
 
 func TestUnknownVolume_VolumeTemplate(t *testing.T) {
-	type fields struct {
-		Zone               scw.Zone
-		ID                 string
-		Name               string
-		Size               *scw.Size
-		ServerID           *string
-		Boot               *bool
-		IsBlockVolume      bool
-		InstanceVolumeType instanceSDK.VolumeVolumeType
-	}
 	tests := []struct {
 		name   string
 		volume *instance.UnknownVolume

internal/services/tem/helpers.go

@@ -1,15 +1,13 @@
 package tem
 
 import (
-	"context"
 	"time"
 
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	tem "github.com/scaleway/scaleway-sdk-go/api/tem/v1alpha1"
 	"github.com/scaleway/scaleway-sdk-go/scw"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/regional"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/meta"
-	"github.com/scaleway/terraform-provider-scaleway/v2/internal/transport"
 )
 
 const (
@@ -39,19 +37,3 @@ func NewAPIWithRegionAndID(m interface{}, id string) (*tem.API, scw.Region, stri
 	}
 	return api, region, id, nil
 }
-
-func waitForTemDomain(ctx context.Context, api *tem.API, region scw.Region, id string, timeout time.Duration) (*tem.Domain, error) {
-	retryInterval := defaultDomainRetryInterval
-	if transport.DefaultWaitRetryInterval != nil {
-		retryInterval = *transport.DefaultWaitRetryInterval
-	}
-
-	domain, err := api.WaitForDomain(&tem.WaitForDomainRequest{
-		Region:        region,
-		DomainID:      id,
-		RetryInterval: &retryInterval,
-		Timeout:       scw.TimeDurationPtr(timeout),
-	}, scw.WithContext(ctx))
-
-	return domain, err
-}