Fix(lb): wait on read lb and add wait to sweeper test. (#1028)

Author: Monitob

scaleway/resource_lb.go

@@ -193,7 +193,7 @@ func resourceScalewayLbRead(ctx context.Context, d *schema.ResourceData, meta in
 	}
 
 	retryInterval := DefaultWaitLBRetryInterval
-	res, err := lbAPI.WaitForLb(&lb.ZonedAPIWaitForLBRequest{
+	res, err := lbAPI.WaitForLbInstances(&lb.ZonedAPIWaitForLBInstancesRequest{
 		Zone:          zone,
 		LBID:          ID,
 		Timeout:       scw.TimeDurationPtr(defaultInstanceServerWaitTimeout),

scaleway/resource_lb_ip_test.go

@@ -135,7 +135,7 @@ func testAccCheckScalewayLbIPDestroy(tt *TestTools) resource.TestCheckFunc {
 
 			lbID, lbExist := rs.Primary.Attributes["lb_id"]
 			if lbExist && len(lbID) > 0 {
-				_, err = lbAPI.WaitForLb(&lb.ZonedAPIWaitForLBRequest{
+				_, err = lbAPI.WaitForLbInstances(&lb.ZonedAPIWaitForLBInstancesRequest{
 					Zone:          zone,
 					LBID:          lbID,
 					Timeout:       scw.TimeDurationPtr(defaultInstanceServerWaitTimeout),

scaleway/resource_lb_test.go

@@ -32,6 +32,15 @@ func testSweepLB(_ string) error {
 		}
 
 		for _, l := range listLBs.LBs {
+			_, err = lbAPI.WaitForLbInstances(&lb.ZonedAPIWaitForLBInstancesRequest{
+				LBID:          l.ID,
+				Zone:          zone,
+				Timeout:       scw.TimeDurationPtr(LbWaitForTimeout),
+				RetryInterval: scw.TimeDurationPtr(DefaultWaitLBRetryInterval),
+			})
+			if err != nil {
+				return fmt.Errorf("error waiting for lb in sweeper: %s", err)
+			}
 			err := lbAPI.DeleteLB(&lb.ZonedAPIDeleteLBRequest{
 				LBID:      l.ID,
 				ReleaseIP: true,