Skip to content

Commit 4ef8327

Browse files
authored
fix(instance-ip-reverse): documentation and test (#1207)
1 parent 97659bb commit 4ef8327

File tree

3 files changed

+943
-7
lines changed

3 files changed

+943
-7
lines changed

docs/resources/instance_ip_reverse_dns.md

+11
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,22 @@ description: |-
88

99
Manages Scaleway Compute Instance IPs Reverse DNS.
1010

11+
Please check our [guide](https://www.scaleway.com/en/docs/compute/instances/how-to/configure-reverse-dns/) for more details
12+
1113
## Example Usage
1214

1315
```hcl
1416
resource "scaleway_instance_ip" "server_ip" {}
1517
18+
resource "scaleway_domain_record" "tf_A" {
19+
dns_zone = "scaleway.com"
20+
name = "www"
21+
type = "A"
22+
data = ""${scaleway_instance_ip.server_ip.address}""
23+
ttl = 3600
24+
priority = 1
25+
}
26+
1627
resource "scaleway_instance_ip_reverse_dns" "reverse" {
1728
ip_id = scaleway_instance_ip.server_ip.id
1829
reverse = "www.scaleway.com"

scaleway/resource_instance_ip_reverse_dns_test.go

+18-7
Original file line numberDiff line numberDiff line change
@@ -1,30 +1,41 @@
11
package scaleway
22

33
import (
4+
"fmt"
45
"testing"
56

67
"github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource"
78
)
89

910
func TestAccScalewayInstanceIPReverseDns_Basic(t *testing.T) {
10-
t.Skip("Skipping Reverse DNS because the domain is we can not execute dig +short www.scaleway-terraform.com ")
1111
tt := NewTestTools(t)
1212
defer tt.Cleanup()
13+
testDNSZone := fmt.Sprintf("tf.%s", testDomain)
1314
resource.ParallelTest(t, resource.TestCase{
1415
PreCheck: func() { testAccPreCheck(t) },
1516
ProviderFactories: tt.ProviderFactories,
1617
CheckDestroy: testAccCheckScalewayInstanceIPDestroy(tt),
1718
Steps: []resource.TestStep{
1819
{
19-
Config: `
20-
resource "scaleway_instance_ip" "ip" {}
20+
Config: fmt.Sprintf(`
21+
resource "scaleway_instance_ip" "main" {}
22+
23+
resource "scaleway_domain_record" "tf_A" {
24+
dns_zone = %[1]q
25+
name = "tf"
26+
type = "A"
27+
data = "${scaleway_instance_ip.main.address}"
28+
ttl = 3600
29+
priority = 1
30+
}
31+
2132
resource "scaleway_instance_ip_reverse_dns" "base" {
22-
ip_id = scaleway_instance_ip.ip.id
23-
reverse = "www.scaleway-terraform.com"
33+
ip_id = scaleway_instance_ip.main.id
34+
reverse = %[2]q
2435
}
25-
`,
36+
`, testDomain, testDNSZone),
2637
Check: resource.ComposeTestCheckFunc(
27-
resource.TestCheckResourceAttr("scaleway_instance_ip_reverse_dns.base", "reverse", "www.scaleway-terraform.com"),
38+
resource.TestCheckResourceAttr("scaleway_instance_ip_reverse_dns.base", "reverse", testDNSZone),
2839
),
2940
},
3041
{

0 commit comments

Comments
 (0)