fix(instance): ensure that tags are removed when deleted in tf (#672)

Author: remyleone

scaleway/helpers.go

@@ -375,7 +375,7 @@ func expandStringWithDefault(data interface{}, defaultValue string) string {
 
 func expandStrings(data interface{}) []string {
 	if data == nil {
-		return nil
+		return []string{}
 	}
 	stringSlice := []string(nil)
 	for _, s := range data.([]interface{}) {

scaleway/resource_instance_server.go

@@ -643,7 +643,7 @@ func resourceScalewayInstanceServerUpdate(ctx context.Context, d *schema.Resourc
 			return diag.FromErr(err)
 		}
 	}
-	_, err = instanceAPI.UpdateServer(updateRequest)
+	_, err = instanceAPI.UpdateServer(updateRequest, scw.WithContext(ctx))
 	if err != nil {
 		return diag.FromErr(err)
 	}

scaleway/resource_instance_server_test.go

@@ -936,3 +936,43 @@ func TestAccScalewayInstanceServer_Bootscript(t *testing.T) {
 		},
 	})
 }
+
+func TestAccScalewayInstanceServer_AlterTags(t *testing.T) {
+	tt := NewTestTools(t)
+	defer tt.Cleanup()
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { testAccPreCheck(t) },
+		ProviderFactories: tt.ProviderFactories,
+		CheckDestroy:      testAccCheckScalewayInstanceServerDestroy(tt),
+		Steps: []resource.TestStep{
+			{
+				Config: `
+					resource "scaleway_instance_server" "base" {
+						type  = "DEV1-L"
+						image = "ubuntu_focal"
+						state = "stopped"
+						tags = [ "front", "web" ]
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckScalewayInstanceServerExists(tt, "scaleway_instance_server.base"),
+					resource.TestCheckResourceAttr("scaleway_instance_server.base", "tags.0", "front"),
+					resource.TestCheckResourceAttr("scaleway_instance_server.base", "tags.1", "web"),
+				),
+			},
+			{
+				Config: `
+					resource "scaleway_instance_server" "base" {
+						type  = "DEV1-L"
+						state = "stopped"
+						image = "ubuntu_focal"
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckScalewayInstanceServerExists(tt, "scaleway_instance_server.base"),
+					resource.TestCheckNoResourceAttr("scaleway_instance_server.base", "tags"),
+				),
+			},
+		},
+	})
+}