feat(marketplace_image): add image_type filter (#2943)

* feat(marketplace_image): add image_type filter

* add local image type validation

Author: Codelax

docs/data-sources/marketplace_image.md

@@ -23,6 +23,8 @@ to find the right `label`.
 - `instance_type` - (Optional, default `DEV1-S`) The instance type the image is compatible with.
 You find all the available types on the [pricing page](https://www.scaleway.com/en/pricing/).
 
+- `image_type` - (Optional, default `instance_local`) The local image type, `instance_local` or `instance_sbs`.
+
 - `zone` - (Defaults to [provider](../index.md#zone) `zone`) The [zone](../guides/regions_and_zones.md#zones) in which the image exists.
 
 ## Attributes Reference

internal/services/marketplace/image_data_source.go

@@ -9,6 +9,7 @@ import (
 	"github.com/scaleway/scaleway-sdk-go/scw"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/datasource"
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/locality/zonal"
+	"github.com/scaleway/terraform-provider-scaleway/v2/internal/verify"
 )
 
 func DataSourceImage() *schema.Resource {
@@ -26,6 +27,13 @@ func DataSourceImage() *schema.Resource {
 				Default:     "DEV1-S",
 				Description: "The instance commercial type of the desired image",
 			},
+			"image_type": {
+				Type:             schema.TypeString,
+				Optional:         true,
+				Default:          "instance_local", // Keep the old default as default to avoid a breaking change.
+				Description:      "The type of the desired image, instance_local or instance_sbs",
+				ValidateDiagFunc: verify.ValidateEnum[marketplace.LocalImageType](),
+			},
 			"zone": zonal.Schema(),
 		},
 	}
@@ -41,7 +49,7 @@ func DataSourceMarketplaceImageRead(ctx context.Context, d *schema.ResourceData,
 		ImageLabel:     d.Get("label").(string),
 		CommercialType: d.Get("instance_type").(string),
 		Zone:           zone,
-		Type:           marketplace.LocalImageTypeInstanceLocal,
+		Type:           marketplace.LocalImageType(d.Get("image_type").(string)),
 	}, scw.WithContext(ctx))
 	if err != nil {
 		return diag.FromErr(err)
@@ -52,6 +60,7 @@ func DataSourceMarketplaceImageRead(ctx context.Context, d *schema.ResourceData,
 	_ = d.Set("zone", zone)
 	_ = d.Set("label", d.Get("label"))
 	_ = d.Set("instance_type", d.Get("type"))
+	_ = d.Set("image_type", image.Type)
 
 	return nil
 }

internal/services/marketplace/image_data_source_test.go

@@ -24,6 +24,31 @@ func TestAccDataSourceMarketplaceImage_Basic(t *testing.T) {
 				Check: resource.ComposeTestCheckFunc(
 					instancechecks.DoesImageExists(tt, "data.scaleway_marketplace_image.test1"),
 					resource.TestCheckResourceAttr("data.scaleway_marketplace_image.test1", "label", "ubuntu_focal"),
+					resource.TestCheckResourceAttr("data.scaleway_marketplace_image.test1", "image_type", "instance_local"),
+				),
+			},
+		},
+	})
+}
+
+func TestAccDataSourceMarketplaceImage_SBS(t *testing.T) {
+	tt := acctest.NewTestTools(t)
+	defer tt.Cleanup()
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { acctest.PreCheck(t) },
+		ProviderFactories: tt.ProviderFactories,
+		Steps: []resource.TestStep{
+			{
+				Config: `
+					data "scaleway_marketplace_image" "test1" {
+						label = "ubuntu_focal"
+						image_type = "instance_sbs"
+					}
+					`,
+				Check: resource.ComposeTestCheckFunc(
+					instancechecks.DoesImageExists(tt, "data.scaleway_marketplace_image.test1"),
+					resource.TestCheckResourceAttr("data.scaleway_marketplace_image.test1", "label", "ubuntu_focal"),
+					resource.TestCheckResourceAttr("data.scaleway_marketplace_image.test1", "image_type", "instance_sbs"),
 				),
 			},
 		},