Fix(k8s): set waiting pool ready as mandatory (#1045)

Author: Monitob

scaleway/helpers_k8s.go

@@ -42,7 +42,7 @@ const (
 	defaultK8SPoolTimeout                = 10 * time.Minute
 	K8SClusterWaitForPoolRequiredTimeout = 10 * time.Minute
 	K8SClusterWaitForDeletedTimeout      = 10 * time.Minute
-	K8SPoolWaitForReadyTimeout           = 10 * time.Minute
+	K8SPoolWaitForReadyTimeout           = 15 * time.Minute
 )
 
 func k8sAPIWithRegion(d *schema.ResourceData, m interface{}) (*k8s.API, scw.Region, error) {

scaleway/resource_k8s_pool.go

@@ -96,7 +96,7 @@ func resourceScalewayK8SPool() *schema.Resource {
 			"wait_for_pool_ready": {
 				Type:        schema.TypeBool,
 				Optional:    true,
-				Default:     false,
+				Default:     true,
 				Description: "Whether to wait for the pool to be ready",
 			},
 			"placement_group_id": {
@@ -277,15 +277,15 @@ func resourceScalewayK8SPoolCreate(ctx context.Context, d *schema.ResourceData,
 
 	d.SetId(newRegionalIDString(region, res.ID))
 
-	if waitForCluster {
-		_, err = waitK8SCluster(ctx, k8sAPI, region, cluster.ID)
+	if d.Get("wait_for_pool_ready").(bool) { // wait for the pool to be ready if specified (including all its nodes)
+		err = waitK8SPoolReady(ctx, k8sAPI, region, res.ID)
 		if err != nil {
 			return diag.FromErr(err)
 		}
 	}
 
-	if d.Get("wait_for_pool_ready").(bool) { // wait for the pool to be ready if specified (including all its nodes)
-		err = waitK8SPoolReady(ctx, k8sAPI, region, res.ID)
+	if waitForCluster {
+		_, err = waitK8SCluster(ctx, k8sAPI, region, cluster.ID)
 		if err != nil {
 			return diag.FromErr(err)
 		}