feat:(cockpit): add push urls to cockpit datasources (#2700)

* t add push url in ressource source

* handle error in createPushURL

* fix test

Author: jremy42

docs/resources/cockpit_source.md

@@ -44,8 +44,14 @@ In addition to all arguments above, the following attributes are exported:
 
 ~> **Important:** Data sources' IDs are [regional](../guides/regions_and_zones.md#resource-ids), which means that they include the region, in the `{region}/{id}` format. For example, if your data source is located in the `fr-par` region, its ID would look like the following: `fr-par/11111111-1111-1111-1111-111111111111`.
 
+<<<<<<< HEAD
 - `url` - The URL of the data source.
 - `origin` - The origin of the data source.
+=======
+- `url` - The URL of the cockpit data source.
+- `push_url` - The URL endpoint used for pushing data to the cockpit data source.
+- `origin` - The origin of the cockpit data source.
+>>>>>>> c02687d4 (feat:(cockpit): add push urls to cockpit datasources (#2700))
 - `synchronized_with_grafana` - Indicates whether the data source is synchronized with Grafana.
 - `created_at` - The date and time the data source was created (in RFC 3339 format).
 - `updated_at` - The date and time the data source was last updated (in RFC 3339 format).

internal/services/cockpit/cockpit.go

@@ -182,7 +182,7 @@ func ResourceCockpitRead(ctx context.Context, d *schema.ResourceData, m interfac
 	endpoints := flattenCockpitEndpoints(dataSourcesRes.DataSources, grafana.GrafanaURL, alertManagerURL)
 
 	_ = d.Set("endpoints", endpoints)
-	_ = d.Set("push_url", createCockpitPushURL(endpoints))
+	_ = d.Set("push_url", createCockpitPushURLList(endpoints))
 
 	return nil
 }

internal/services/cockpit/cockpit_data_source.go

@@ -91,7 +91,7 @@ func dataSourceCockpitRead(ctx context.Context, d *schema.ResourceData, m interf
 	endpoints := flattenCockpitEndpoints(dataSourcesRes.DataSources, grafana.GrafanaURL, alertManagerURL)
 
 	_ = d.Set("endpoints", endpoints)
-	_ = d.Set("push_url", createCockpitPushURL(endpoints))
+	_ = d.Set("push_url", createCockpitPushURLList(endpoints))
 	d.SetId(projectID)
 	return nil
 }

internal/services/cockpit/cockpit_test.go

@@ -95,7 +95,7 @@ func TestAccCockpit_WithSourceEndpoints(t *testing.T) {
 
 					resource "scaleway_cockpit_grafana_user" "main" {
 					  project_id = scaleway_account_project.project.id
-					  login = "cockpit_test"
+					  login = "cockpit_test_endpoint"
 					  role = "editor"
 					}
 					

internal/services/cockpit/helpers_cockpit.go

@@ -20,6 +20,7 @@ const (
 	DefaultCockpitTimeout = 5 * time.Minute
 	pathMetricsURL        = "/api/v1/push"
 	pathLogsURL           = "/loki/api/v1/push"
+	pathTracesURL         = "/otlp/v1/traces"
 )
 
 // NewGlobalAPI returns a new global cockpit API.

internal/services/cockpit/source.go

@@ -68,6 +68,11 @@ func ResourceCockpitSource() *schema.Resource {
 				Computed:    true,
 				Description: "The date and time of the last update of the cockpit datasource",
 			},
+			"push_url": {
+				Type:        schema.TypeString,
+				Computed:    true,
+				Description: "The URL endpoint used for pushing data to the cockpit data source.",
+			},
 			"project_id": account.ProjectIDSchema(),
 			"region":     regional.Schema(),
 		},
@@ -112,6 +117,11 @@ func ResourceCockpitSourceRead(ctx context.Context, d *schema.ResourceData, meta
 		return diag.FromErr(err)
 	}
 
+	pushURL, err := createCockpitPushURL(res.Type, res.URL)
+	if err != nil {
+		return diag.FromErr(err)
+	}
+
 	_ = d.Set("name", res.Name)
 	_ = d.Set("type", res.Type.String())
 	_ = d.Set("url", res.URL)
@@ -121,6 +131,7 @@ func ResourceCockpitSourceRead(ctx context.Context, d *schema.ResourceData, meta
 	_ = d.Set("created_at", types.FlattenTime(res.CreatedAt))
 	_ = d.Set("updated_at", types.FlattenTime(res.UpdatedAt))
 	_ = d.Set("project_id", res.ProjectID)
+	_ = d.Set("push_url", pushURL)
 
 	return nil
 }

internal/services/cockpit/source_test.go

@@ -12,7 +12,7 @@ import (
 	"github.com/scaleway/terraform-provider-scaleway/v2/internal/services/cockpit"
 )
 
-func TestAccCockpitSource_Basic(t *testing.T) {
+func TestAccCockpitSource_Basic_metrics(t *testing.T) {
 	tt := acctest.NewTestTools(t)
 	defer tt.Cleanup()
 
@@ -39,6 +39,46 @@ func TestAccCockpitSource_Basic(t *testing.T) {
 					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "type", "metrics"),
 					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "region", "fr-par"),
 					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "url"),
+					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "push_url"),
+					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "origin"),
+					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "created_at"),
+					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "updated_at"),
+					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "synchronized_with_grafana"),
+					resource.TestCheckResourceAttrPair("scaleway_cockpit_source.main", "project_id", "scaleway_account_project.project", "id"),
+				),
+			},
+		},
+	})
+}
+
+func TestAccCockpitSource_Basic_logs(t *testing.T) {
+	tt := acctest.NewTestTools(t)
+	defer tt.Cleanup()
+
+	resource.ParallelTest(t, resource.TestCase{
+		PreCheck:          func() { acctest.PreCheck(t) },
+		ProviderFactories: tt.ProviderFactories,
+		CheckDestroy:      isSourceDestroyed(tt),
+		Steps: []resource.TestStep{
+			{
+				Config: `
+					resource "scaleway_account_project" "project" {
+						name = "tf_tests_cockpit_datasource_basic"
+				  	}
+
+					resource "scaleway_cockpit_source" "main" {
+					  project_id = scaleway_account_project.project.id
+					  name       = "my-source"
+					  type       = "logs"
+					}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					isSourcePresent(tt, "scaleway_cockpit_source.main"),
+					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "name", "my-source"),
+					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "type", "logs"),
+					resource.TestCheckResourceAttr("scaleway_cockpit_source.main", "region", "fr-par"),
+					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "url"),
+					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "push_url"),
 					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "origin"),
 					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "created_at"),
 					resource.TestCheckResourceAttrSet("scaleway_cockpit_source.main", "updated_at"),