chore: fix checkout and setup-go ordering to optimize cache usage (#2678)

Author: remyleone

.github/workflows/acceptance-tests.yaml

@@ -43,12 +43,13 @@ jobs:
           - webhosting
     runs-on: ubuntu-latest
     steps:
+      # Checkout should always be before setup-go to ensure caching is working
+      - name: Checkout
+        uses: actions/checkout@v4
       - name: Install Go
         uses: actions/setup-go@v5
         with:
           go-version: 1.22
-      - name: Checkout
-        uses: actions/checkout@v4
       - name: Run Acceptance Tests
         run: go test -v ./internal/services/${{ matrix.products }} -timeout=2h
         env:
@@ -66,12 +67,13 @@ jobs:
       fail-fast: false
     runs-on: ubuntu-latest
     steps:
+      # Checkout should always be before setup-go to ensure caching is working
+      - name: Checkout
+        uses: actions/checkout@v4
       - name: Install Go
         uses: actions/setup-go@v5
         with:
           go-version: 1.22
-      - name: Checkout
-        uses: actions/checkout@v4
       - name: Run scwconfig tests
         run: go test -v ./internal/services/scwconfig -timeout=2m
         env:

.github/workflows/coverage.yml

@@ -9,6 +9,7 @@ jobs:
   build:
     runs-on: ubuntu-latest
     steps:
+      # Checkout should always be before setup-go to ensure caching is working
       - uses: actions/checkout@v4
         with:
           fetch-depth: 2

.github/workflows/documentation.yml

@@ -38,6 +38,7 @@ jobs:
   misspell:
     runs-on: ubuntu-latest
     steps:
+      # Checkout should always be before setup-go to ensure caching is working
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:

.github/workflows/nightly.yml

@@ -44,12 +44,13 @@ jobs:
           - webhosting
     runs-on: ubuntu-latest
     steps:
+      # Checkout should always be before setup-go to ensure caching is working
+      - name: Checkout
+        uses: actions/checkout@v4
       - name: Install Go
         uses: actions/setup-go@v5
         with:
           go-version: 1.22
-      - name: Checkout
-        uses: actions/checkout@v4
       - name: Run Acceptance Tests
         run: go test -v ./internal/services/${{ matrix.products }} -timeout=4h
         env:
@@ -92,12 +93,13 @@ jobs:
     needs: nightly
     if: always()
     steps:
+      # Checkout should always be before setup-go to ensure caching is working
+      - name: Checkout
+        uses: actions/checkout@v4
       - name: Install Go
         uses: actions/setup-go@v5
         with:
           go-version: 1.22
-      - name: Checkout
-        uses: actions/checkout@v4
       - name: Run sweepers
         run: make sweep
         env:

.github/workflows/release.yml

@@ -18,6 +18,7 @@ jobs:
   goreleaser:
     runs-on: ubuntu-latest
     steps:
+      # Checkout should always be before setup-go to ensure caching is working
       - name: Checkout
         uses: actions/checkout@v4
 

.github/workflows/tfproviderlint.yml

@@ -9,6 +9,7 @@ jobs:
   tfproviderlint:
     runs-on: ubuntu-latest
     steps:
+      # Checkout should always be before setup-go to ensure caching is working
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:
@@ -20,6 +21,7 @@ jobs:
   tfproviderdocs:
     runs-on: ubuntu-latest
     steps:
+      # Checkout should always be before setup-go to ensure caching is working
       - uses: actions/checkout@v4
       - uses: actions/setup-go@v5
         with:

.github/workflows/unit-tests.yaml

@@ -12,14 +12,15 @@ jobs:
         platform: [ubuntu-latest]
     runs-on: ${{ matrix.platform }}
     steps:
-    - name: Install Go
-      uses: actions/setup-go@v5
-      with:
-        go-version: ${{ matrix.go-version }}
+    # Checkout should always be before setup-go to ensure caching is working
     - name: Checkout
       uses: actions/checkout@v4
       with:
         fetch-depth: 1
+    - name: Install Go
+      uses: actions/setup-go@v5
+      with:
+        go-version: ${{ matrix.go-version }}
     - name: Build binaries
       run: make build
     - name: Run unit tests