feat: only return warnings for non public locality (#816)

Author: remyleone

go.mod

@@ -5,6 +5,7 @@ require (
 	github.com/dnaeon/go-vcr v1.1.0
 	github.com/dustin/go-humanize v1.0.0
 	github.com/google/go-cmp v0.5.5
+	github.com/hashicorp/go-cty v1.4.1-0.20200414143053-d3edf31b6320 // indirect
 	github.com/hashicorp/go-retryablehttp v0.6.8
 	github.com/hashicorp/terraform-plugin-sdk/v2 v2.5.0
 	github.com/scaleway/scaleway-sdk-go v1.0.0-beta.7.0.20210414083420-b36f019ca892

scaleway/helpers.go

@@ -8,6 +8,8 @@ import (
 	"strings"
 	"time"
 
+	"github.com/hashicorp/go-cty/cty"
+	"github.com/hashicorp/terraform-plugin-sdk/v2/diag"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/schema"
 	"github.com/hashicorp/terraform-plugin-sdk/v2/helper/validation"
 	"github.com/scaleway/scaleway-sdk-go/namegenerator"
@@ -256,15 +258,12 @@ func zoneSchema() *schema.Schema {
 		allZones = append(allZones, z.String())
 	}
 	return &schema.Schema{
-		Type:        schema.TypeString,
-		Description: "The zone you want to attach the resource to",
-		Optional:    true,
-		ForceNew:    true,
-		Computed:    true,
-		ValidateFunc: validation.StringInSlice(
-			allZones,
-			true,
-		),
+		Type:             schema.TypeString,
+		Description:      "The zone you want to attach the resource to",
+		Optional:         true,
+		ForceNew:         true,
+		Computed:         true,
+		ValidateDiagFunc: validateStringInSliceWithWarning(allZones, "zone"),
 	}
 }
 
@@ -275,15 +274,28 @@ func regionSchema() *schema.Schema {
 		allRegions = append(allRegions, z.String())
 	}
 	return &schema.Schema{
-		Type:        schema.TypeString,
-		Description: "The region you want to attach the resource to",
-		Optional:    true,
-		ForceNew:    true,
-		Computed:    true,
-		ValidateFunc: validation.StringInSlice(
-			allRegions,
-			true,
-		),
+		Type:             schema.TypeString,
+		Description:      "The region you want to attach the resource to",
+		Optional:         true,
+		ForceNew:         true,
+		Computed:         true,
+		ValidateDiagFunc: validateStringInSliceWithWarning(allRegions, "region"),
+	}
+}
+
+// validateStringInSliceWithWarning helps to only returns warnings in case we got a non public locality passed
+func validateStringInSliceWithWarning(correctValues []string, field string) func(i interface{}, path cty.Path) diag.Diagnostics {
+	return func(i interface{}, path cty.Path) diag.Diagnostics {
+		_, rawErr := validation.StringInSlice(correctValues, true)(i, field)
+		var res diag.Diagnostics
+		for _, e := range rawErr {
+			res = append(res, diag.Diagnostic{
+				Severity:      diag.Warning,
+				Summary:       e.Error(),
+				AttributePath: path,
+			})
+		}
+		return res
 	}
 }