set ttl to optional and test its removal

Author: Codelax

internal/services/secret/helpers.go

@@ -141,11 +141,14 @@ func expandEphemeralPolicy(rawSchemaPolicy any) (*secret.EphemeralPolicy, error)
 	}
 
 	policy := &secret.EphemeralPolicy{
-		TimeToLive:          scw.NewDurationFromTimeDuration(*ttl),
 		ExpiresOnceAccessed: types.ExpandBoolPtr(rawPolicy["expires_once_accessed"]),
 		Action:              secret.EphemeralPolicyAction(rawPolicy["action"].(string)),
 	}
 
+	if ttl != nil {
+		policy.TimeToLive = scw.NewDurationFromTimeDuration(*ttl)
+	}
+
 	return policy, nil
 }
 

internal/services/secret/secret.go

@@ -88,7 +88,7 @@ func ResourceSecret() *schema.Resource {
 				Elem: &schema.Resource{
 					Schema: map[string]*schema.Schema{
 						"ttl": {
-							Required:         true,
+							Optional:         true,
 							Type:             schema.TypeString,
 							DiffSuppressFunc: dsf.Duration,
 							ValidateFunc:     verify.IsDuration(),

internal/services/secret/secret_test.go

@@ -264,6 +264,27 @@ func TestAccSecret_EphemeralPolicy(t *testing.T) {
 					acctest.CheckResourceAttrUUID("scaleway_secret.main", "id"),
 				),
 			},
+			{
+				Config: `
+				resource "scaleway_secret" "main" {
+					name = "test-secret-policy-secret"
+					ephemeral_policy {
+						action = "delete"
+						expires_once_accessed = true
+					}
+				}
+				`,
+				Check: resource.ComposeTestCheckFunc(
+					testAccCheckSecretExists(tt, "scaleway_secret.main"),
+					resource.TestCheckResourceAttr("scaleway_secret.main", "name", "test-secret-policy-secret"),
+					resource.TestCheckResourceAttr("scaleway_secret.main", "path", "/"),
+					resource.TestCheckResourceAttr("scaleway_secret.main", "ephemeral_policy.#", "1"),
+					resource.TestCheckResourceAttr("scaleway_secret.main", "ephemeral_policy.0.ttl", ""),
+					resource.TestCheckResourceAttr("scaleway_secret.main", "ephemeral_policy.0.action", "delete"),
+					resource.TestCheckResourceAttr("scaleway_secret.main", "ephemeral_policy.0.expires_once_accessed", "true"),
+					acctest.CheckResourceAttrUUID("scaleway_secret.main", "id"),
+				),
+			},
 		},
 	})
 }