Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scaleway_secret_version datasource - Filters additions #2655

Closed
jgalais opened this issue Jul 8, 2024 · 3 comments
Closed

scaleway_secret_version datasource - Filters additions #2655

jgalais opened this issue Jul 8, 2024 · 3 comments
Assignees
Labels
enhancement priority:high New features secret Managed Secret Manager issues, bugs and feature requests

Comments

@jgalais
Copy link

jgalais commented Jul 8, 2024

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Hello,

I use "scaleway_secret_version" data_source but some filters can be add to enhanced this datasource.

Filter addition proposal:

  • revision = "latest"

It's an important thing because currently you must target the specific version.
If you want to split the secret version cycle and your Infrastructure as Code you can't do.

Can you add that on this resource too to have complete integration ?
i'am available if you have questions.

New or Affected Resource(s)

  • scaleway_secret_version (Data Source)

Potential Terraform Configuration

data "scaleway_secret_version" "application_admin_password" {
  project_id = "XXXXXXXX"
  revision   = "latest"
}

Thank you for your work.

Regards,

@Codelax Codelax added secret Managed Secret Manager issues, bugs and feature requests priority:high New features labels Jul 8, 2024
@jgalais
Copy link
Author

jgalais commented Jul 11, 2024

Hello,

I edited my message to drop the path filter.
It was a poor understanding on my part because the path can be use on "scaleway_secret" data source.

Regards,

@Codelax
Copy link
Member

Codelax commented Aug 7, 2024

Hi, as it is supported by the API, you should already be able to use latest in your revision filter.
I added its usage to our tests and it seems to work fine:

data "scaleway_secret_version" "data_by_name_latest" {
  secret_name = scaleway_secret.main.name
  revision    = "latest"
}

Thanks for reporting this, I also added a bit more info to the documentation

@jgalais
Copy link
Author

jgalais commented Aug 7, 2024

Hello,

Thank you for your work.

@jgalais jgalais closed this as completed Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement priority:high New features secret Managed Secret Manager issues, bugs and feature requests
Projects
None yet
Development

No branches or pull requests

3 participants