Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fp_model's mulreduce to not check limbsize in run-time #74

Open
ValarDragon opened this issue Oct 11, 2020 · 0 comments
Open

Change fp_model's mulreduce to not check limbsize in run-time #74

ValarDragon opened this issue Oct 11, 2020 · 0 comments

Comments

@ValarDragon
Copy link
Member

The multiplication function in a finite field currently checks in runtime what the limb size is, when its instead known at compile time as its a template parameter.

Line where we check this:

I don't know if this is optimized out by the compiler on all platforms, but if it isn't this is potentially quite bad for the instruction cache (in addition to slight overhead due to the branch-predicted conditional)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant