Remove the YourKit profiling callback (spotbugs#289)

Author: Andreas Sewe

CHANGELOG.md

@@ -4,6 +4,9 @@ This is the changelog for SpotBugs. This follows [Keep a Changelog v0.3](http://
 
 ## Unreleased (2017/??/??)
 
+### Removed
+
+* The `YourKitProfiler` class has been removed and the `findbugs.yourkit.enabled` system property is no longer supported ([#289](https://github.com/spotbugs/spotbugs/issues/289))
 
 ## 3.1.0-RC4 (2017/Jul/21)
 

spotbugs/lib/yjp-controller-api-redist.jar

@@ -344,13 +344,6 @@ <h2>
                     project, including founding work by <a href="http://goose.ycp.edu/~dhovemey/">David Hovemeyer</a>
                     and the web cloud infrastructure by Keith Lea.
                 </p>
-                <p>
-                    YourKit is kindly supporting open source projects with its full-featured Java Profiler. YourKit, LLC
-                    is creator of innovative and intelligent tools for profiling Java and .NET applications. Take a look
-                    at YourKit's leading software products: <a href="http://www.yourkit.com/java/profiler/index.jsp">YourKit
-                        Java Profiler</a> and <a href="http://www.yourkit.com/.net/profiler/index.jsp">YourKit .NET
-                        Profiler</a>.
-                </p>
                 <p>
                     The FindBugs project also uses <a href="http://www.atlassian.com/software/fisheye/">FishEye</a> and
                     <a href="http://www.atlassian.com/software/clover/">Clover</a>, which are generously provided by <a

spotbugs/src/doc/index.html

@@ -69,7 +69,6 @@
 import edu.umd.cs.findbugs.detect.NoteSuppressedWarnings;
 import edu.umd.cs.findbugs.filter.FilterException;
 import edu.umd.cs.findbugs.log.Profiler;
-import edu.umd.cs.findbugs.log.YourKitController;
 import edu.umd.cs.findbugs.plan.AnalysisPass;
 import edu.umd.cs.findbugs.plan.ExecutionPlan;
 import edu.umd.cs.findbugs.plan.OrderingConstraintException;
@@ -118,8 +117,6 @@ public class FindBugs2 implements IFindBugsEngine {
 
     private ExecutionPlan executionPlan;
 
-    private final YourKitController yourkitController = new YourKitController();
-
     private String currentClassName;
 
     private FindBugsProgress progress;
@@ -986,7 +983,6 @@ private void analyzeApplication() throws InterruptedException {
             bugReporter.getProjectStats().setReferencedClasses(referencedClassSet.size());
             for (Iterator<AnalysisPass> passIterator = executionPlan.passIterator(); passIterator.hasNext();) {
                 AnalysisPass pass = passIterator.next();
-                yourkitController.advanceGeneration("Pass " + passCount);
                 // The first pass is generally a non-reporting pass which
                 // gathers information about referenced classes.
                 boolean isNonReportingFirstPass = multiplePasses && passCount == 0;
@@ -1047,10 +1043,6 @@ public Collection<ClassDescriptor> getOutEdges(ClassDescriptor e) {
                                 classCollection.size(), classDescriptor);
                     }
                     count++;
-                    if (!isNonReportingFirstPass && count % 1000 == 0) {
-                        yourkitController.advanceGeneration(String.format("Pass %d.%02d", passCount, count/1000));
-                    }
-
 
                     // Check to see if class is excluded by the class screener.
                     // In general, we do not want to screen classes from the
@@ -1121,9 +1113,6 @@ public Collection<ClassDescriptor> getOutEdges(ClassDescriptor e) {
                     }
                 }
 
-                if (!passIterator.hasNext()) {
-                    yourkitController.captureMemorySnapshot();
-                }
                 // Call finishPass on each detector
                 for (Detector2 detector : detectorList) {
                     detector.finishPass();