Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomLicense has a different name and structure relative to SPDX 2.3 #223

Closed
goneall opened this issue Apr 23, 2023 · 1 comment
Closed
Labels
Profile:Licensing Licensing Profile and related matters
Milestone

Comments

@goneall
Copy link
Member

goneall commented Apr 23, 2023

Compared to the SPDX 2.3 UML class diagram, the SPDX 2.3 ExtractedLicenseText is named CustomLicense. There is also an additional abstract class in SPDX 2.3 SimpleLicensingInfo which is a superclass of both License and ExtractedLicenseText.

Since the class is concrete, the name change will impact serializations. We should either change the name back or write up some reasoning for the change.

The abstract classes have less of an impact. I personally like the proposed 3.0 structure, but it will create some incompatibilities in some of the current libraries.

@goneall goneall added the Profile:Licensing Licensing Profile and related matters label Apr 23, 2023
@swinslow
Copy link
Member

swinslow commented May 4, 2023

Thanks @goneall. For this one, I'm inclined to keep it as CustomLicense. I think that the context change from the historical ExtractedLicenseText name is sufficiently different that CustomLicense is an appropriate name here.

Hopefully this also won't cause compatibility problems for tooling such as with the LicenseExpression vs. AnyLicenseInfo item in #222.

@swinslow swinslow closed this as completed May 4, 2023
@swinslow swinslow added this to the 3.0-rc milestone May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Profile:Licensing Licensing Profile and related matters
Projects
None yet
Development

No branches or pull requests

2 participants