-
Notifications
You must be signed in to change notification settings - Fork 526
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENHANCEMENT] Create GitHub releases for Helm charts #861
Comments
This is expected, since it was a breaking change, shifting placement of image to outside of reloader struct |
i get versioning the chart independently from reloader itself, but i think there are probably quite a few folks out there confused by PRs submitted by renovate or similar tools. the lack of a changelog or other communication that the chart is now versioning independently of the app is likely to cause some initial confusion. i think its amplified by the fact that the commit message and the chart versioning dont line up. |
i think it was mentioned in atleast three release notes (as suggested by a community member) when the change was happening. feel free to let us know what other ways can be used to communicate this |
I only started using Reloader this year, so I did not see previous announcements about a version split. Regardless, there is no information on v2.0.0 of the chart. After being presented with a v2 by renovate, I came here with the question "What's the breaking change in v2?" and looked for releases and (Helm chart related) tags to compare manually. Currently there's no easily digestible information other than digging through code and the commit history. "Maybe some automated versioning error accidentally released a v2" was very high on my list of possibilities. |
right, what we could do is to create github releases for helm charts as well, and then maintain changes there for easy tracking. |
feel free to drop suggestions. |
+1. This is typically how other projects handle releases if the chart is versioned separately from the application. For example: ingress-nginx. |
yeah, releases for the chart would be great! im not super opinionated about where the release notes are as long as theyre easy to find. and you're right @MuneebAijaz, this change was prominently displayed in the main release notes ahead of time. not speaking for everyone, but reloader has been so good about not breaking during upgrades that i dont typically look at the release notes for minor versions 😓 i just test in staging and go from there. anyway thanks for the discussion 😄 |
Describe the bug
The chart version has been updated to 2.0.0, despite the commit message suggesting it should have been 1.3.1.
413e805#diff-acbb82e41b20a30197e2d7d588c1d52a5469194125135d074ac16420bbf8280d
The text was updated successfully, but these errors were encountered: