Skip to content

Commit dbea094

Browse files
ndelangenshilman
authored andcommitted
Merge pull request #28853 from storybookjs/norbert/fix-no-install-bug
Bug: CLI `init` failure when `--no-install` passed fixed (cherry picked from commit e5960ff)
1 parent 5f83bde commit dbea094

File tree

2 files changed

+25
-2
lines changed

2 files changed

+25
-2
lines changed

.circleci/config.yml

+17
Original file line numberDiff line numberDiff line change
@@ -594,6 +594,23 @@ jobs:
594594
IN_STORYBOOK_SANDBOX: true
595595
STORYBOOK_INIT_EMPTY_TYPE: << parameters.template >>
596596
STORYBOOK_DISABLE_TELEMETRY: true
597+
- when:
598+
condition:
599+
equal: ["react-vite-ts", << parameters.template >>]
600+
steps:
601+
- run:
602+
name: Storybook init from empty directory (--skip-install)
603+
command: |
604+
cd code
605+
yarn local-registry --open &
606+
cd ../../
607+
mkdir empty-<< parameters.template >>-no-install
608+
cd empty-<< parameters.template >>-no-install
609+
npx storybook init --yes --skip-install
610+
environment:
611+
IN_STORYBOOK_SANDBOX: true
612+
STORYBOOK_INIT_EMPTY_TYPE: << parameters.template >>
613+
STORYBOOK_DISABLE_TELEMETRY: true
597614
- report-workflow-on-failure
598615
test-portable-stories:
599616
parameters:

code/lib/cli/src/dirs.ts

+8-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { dirname, join } from 'path';
22

3-
import downloadTarball from '@ndelangen/get-tarball';
4-
import getNpmTarballUrl from 'get-npm-tarball-url';
3+
import downloadTarballDefault from '@ndelangen/get-tarball';
4+
import getNpmTarballUrlDefault from 'get-npm-tarball-url';
55

66
import invariant from 'tiny-invariant';
77
import { externalFrameworks } from './project_types';
@@ -22,6 +22,12 @@ const resolveUsingBranchInstall = async (packageManager: JsPackageManager, reque
2222
// FIXME: this might not be the right version for community packages
2323
const version = versions[name] || (await packageManager.latestVersion(request));
2424

25+
// an artifact of esbuild + type=commonjs + exportmap
26+
// @ts-expect-error (default export)
27+
const getNpmTarballUrl = getNpmTarballUrlDefault.default || getNpmTarballUrlDefault;
28+
// @ts-expect-error (default export)
29+
const downloadTarball = downloadTarballDefault.default || downloadTarballDefault;
30+
2531
const url = getNpmTarballUrl(request, version, {
2632
registry: await packageManager.getRegistryURL(),
2733
});

0 commit comments

Comments
 (0)