From 76c474617bc764fb3cf64c9fd0b5cfcf9a4df018 Mon Sep 17 00:00:00 2001
From: IKEDA Soji <ikeda@conversion.co.jp>
Date: Mon, 18 Oct 2021 11:54:24 +0900
Subject: [PATCH] Fix: Invalid POST data breaks sso_login form for all users
 (#1245)

---
 src/cgi/wwsympa.fcgi.in | 17 ++++++-----------
 1 file changed, 6 insertions(+), 11 deletions(-)

diff --git a/src/cgi/wwsympa.fcgi.in b/src/cgi/wwsympa.fcgi.in
index 8cce7763c..168428184 100644
--- a/src/cgi/wwsympa.fcgi.in
+++ b/src/cgi/wwsympa.fcgi.in
@@ -3316,12 +3316,9 @@ sub do_sso_login {
     }
 
     ## This is a CAS service
-    if (defined(
-            my $cas_id =
-                $Conf::Conf{'cas_id'}{$robot}{$in{'auth_service_name'}}
-                {'casnum'}
-        )
-    ) {
+    if (exists $Conf::Conf{'cas_id'}{$robot}{$in{'auth_service_name'}}) {
+        my $cas_id =
+            $Conf::Conf{'cas_id'}{$robot}{$in{'auth_service_name'}}{'casnum'};
         my $cas_server =
             $Conf::Conf{'auth_services'}{$robot}[$cas_id]{'cas_server'};
 
@@ -3341,13 +3338,11 @@ sub do_sso_login {
         }
 
     } elsif (
-        defined(
-            my $sso_id =
-                $Conf::Conf{'generic_sso_id'}{$robot}
-                {$in{'auth_service_name'}}
-        )
+        exists $Conf::Conf{'generic_sso_id'}{$robot}{$in{'auth_service_name'}}
     ) {
         ## Generic SSO
+        my $sso_id =
+            $Conf::Conf{'generic_sso_id'}{$robot}{$in{'auth_service_name'}};
 
         ## If contacted via POST, then redirect the user to the URL for the
         ## access control to apply