Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove undocumented backtick syntax in sympa.conf #1086

Closed
ikedas opened this issue Jan 19, 2021 · 17 comments · Fixed by #1087
Closed

Remove undocumented backtick syntax in sympa.conf #1086

ikedas opened this issue Jan 19, 2021 · 17 comments · Fixed by #1087

Comments

@ikedas
Copy link
Member

ikedas commented Jan 19, 2021

Backtick syntax (`...`) in sympa.conf should be removed, because it allows to execute arbitrary code.

Note: that syntax has not been documented yet.

@racke
Copy link
Contributor

racke commented Jan 19, 2021

Reported as Debian bug: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=980451

@ikedas
Copy link
Member Author

ikedas commented Jan 20, 2021

Comes under #1009.

@racke
Copy link
Contributor

racke commented Jan 20, 2021

Debian uses the backtick in the following fashion:

cookie	`/usr/bin/head -n1 /etc/sympa/cookie`

I can get rid of that, but my question is the cookie value needed at all with recent Sympa release? It is not listed in the skeleton sympa.conf shipped with Sympa.

@ikedas @dverdin Any comment appreciated.

@dverdin

This comment has been minimized.

@racke
Copy link
Contributor

racke commented Jan 20, 2021

Thanks a lot, @dverdin. So I only use the cookie parameter if present and leave it empty when installing Sympa Debian package for the first time.

@dverdin
Copy link
Contributor

dverdin commented Jan 20, 2021

Yes. and that explains why it is not shipped with Sympa anymore.

@racke
Copy link
Contributor

racke commented Jan 20, 2021

OK so it is another spot in the documentation that needs to be filled.

@dverdin
Copy link
Contributor

dverdin commented Jan 20, 2021

I can dot it if nobody disagrees.

@dverdin

This comment has been minimized.

@racke
Copy link
Contributor

racke commented Jan 20, 2021

Yes, but let's move that to a fresh issue.

@dverdin
Copy link
Contributor

dverdin commented Jan 20, 2021

Separation of concerns. You're right.
I'll do a proposal.

@ikedas

This comment has been minimized.

@ikedas

This comment has been minimized.

@ikedas
Copy link
Member Author

ikedas commented Jan 21, 2021

See #1091 for obsoletion of cookie parameter.

@dverdin

This comment has been minimized.

@mitar
Copy link

mitar commented Jul 14, 2023

I am upgrading to a new version of Sympa and I am really sad to see this go. I was using this through cat ... for db_passwd so that the password is not stored in the main file (which can then be baked in into a public Docker image while the password can be then provided at container runtime).

I do not see any alternatives here? Sympa does not support config file includes? So I agree that supporting arbitrary commands it not reasonable, but being able to split config file into smaller files, including them from a directory like sympa.conf.d would be great. Am I right that this is not supported currently?

@mitar
Copy link

mitar commented Jul 14, 2023

I see that there is old issue #17 which is still open, while this feature was removed. So there is no workaround. :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants