Skip to content

Commit fc02801

Browse files
eranhirschRobinMalfaitthecrypticace
committed
Reset dialog element styles (#11069)
* disable useragent styling for dialog * nits * Update src/css/preflight.css * Simplify dialog reset We don’t want to reset everything here. Just the padding should be enough. * Update test --------- Co-authored-by: Robin Malfait <[email protected]> Co-authored-by: Jordan Pittman <[email protected]>
1 parent f662fec commit fc02801

File tree

2 files changed

+140
-128
lines changed

2 files changed

+140
-128
lines changed

‎src/css/preflight.css

+7
Original file line numberDiff line numberDiff line change
@@ -302,6 +302,13 @@ menu {
302302
padding: 0;
303303
}
304304

305+
/*
306+
Reset default styling for dialogs.
307+
*/
308+
dialog {
309+
padding: 0;
310+
}
311+
305312
/*
306313
Prevent resizing textareas horizontally by default.
307314
*/

‎tests/source-maps.test.js

+133-128
Original file line numberDiff line numberDiff line change
@@ -261,139 +261,144 @@ crosscheck(({ stable, oxide }) => {
261261
'2:20 -> 305:0',
262262
'2:6 -> 307:0',
263263
'2:20 -> 309:1',
264-
'2:6 -> 311:0',
265-
'2:6-20 -> 312:2-18',
266-
'2:20 -> 313:0',
267-
'2:6 -> 315:0',
268-
'2:20 -> 318:1',
269-
'2:6 -> 320:0',
270-
'2:6-20 -> 322:2-20',
271-
'2:6-20 -> 323:2-24',
272-
'2:20 -> 324:0',
273-
'2:6 -> 326:0',
274-
'2:20 -> 328:1',
275-
'2:6 -> 330:0',
276-
'2:6-20 -> 332:2-17',
277-
'2:20 -> 333:0',
278-
'2:6 -> 335:0',
279-
'2:20 -> 337:1',
280-
'2:6 -> 338:0',
264+
'2:6 -> 310:0',
265+
'2:6-20 -> 311:2-12',
266+
'2:20 -> 312:0',
267+
'2:6 -> 314:0',
268+
'2:20 -> 316:1',
269+
'2:6 -> 318:0',
270+
'2:6-20 -> 319:2-18',
271+
'2:20 -> 320:0',
272+
'2:6 -> 322:0',
273+
'2:20 -> 325:1',
274+
'2:6 -> 327:0',
275+
'2:6-20 -> 329:2-20',
276+
'2:6-20 -> 330:2-24',
277+
'2:20 -> 331:0',
278+
'2:6 -> 333:0',
279+
'2:20 -> 335:1',
280+
'2:6 -> 337:0',
281281
'2:6-20 -> 339:2-17',
282282
'2:20 -> 340:0',
283283
'2:6 -> 342:0',
284-
'2:20 -> 346:1',
285-
'2:6 -> 348:0',
286-
'2:6-20 -> 356:2-24',
287-
'2:6-20 -> 357:2-32',
288-
'2:20 -> 358:0',
289-
'2:6 -> 360:0',
290-
'2:20 -> 362:1',
291-
'2:6 -> 364:0',
292-
'2:6-20 -> 366:2-17',
293-
'2:6-20 -> 367:2-14',
294-
'2:20 -> 368:0',
295-
'2:6-20 -> 370:0-72',
284+
'2:20 -> 344:1',
285+
'2:6 -> 345:0',
286+
'2:6-20 -> 346:2-17',
287+
'2:20 -> 347:0',
288+
'2:6 -> 349:0',
289+
'2:20 -> 353:1',
290+
'2:6 -> 355:0',
291+
'2:6-20 -> 363:2-24',
292+
'2:6-20 -> 364:2-32',
293+
'2:20 -> 365:0',
294+
'2:6 -> 367:0',
295+
'2:20 -> 369:1',
296296
'2:6 -> 371:0',
297-
'2:6-20 -> 372:2-15',
298-
'2:20 -> 373:0',
299-
'2:6 -> 375:0',
300-
'2:6-20 -> 376:2-26',
301-
'2:6-20 -> 377:2-26',
302-
'2:6-20 -> 378:2-21',
303-
'2:6-20 -> 379:2-21',
304-
'2:6-20 -> 380:2-16',
305-
'2:6-20 -> 381:2-16',
306-
'2:6-20 -> 382:2-16',
307-
'2:6-20 -> 383:2-17',
308-
'2:6-20 -> 384:2-17',
309-
'2:6-20 -> 385:2-15',
310-
'2:6-20 -> 386:2-15',
311-
'2:6-20 -> 387:2-20',
312-
'2:6-20 -> 388:2-40',
313-
'2:6-20 -> 389:2-32',
314-
'2:6-20 -> 390:2-31',
315-
'2:6-20 -> 391:2-30',
316-
'2:6-20 -> 392:2-17',
317-
'2:6-20 -> 393:2-22',
318-
'2:6-20 -> 394:2-24',
319-
'2:6-20 -> 395:2-25',
320-
'2:6-20 -> 396:2-26',
321-
'2:6-20 -> 397:2-20',
322-
'2:6-20 -> 398:2-29',
323-
'2:6-20 -> 399:2-30',
324-
'2:6-20 -> 400:2-40',
325-
'2:6-20 -> 401:2-36',
326-
'2:6-20 -> 402:2-29',
327-
'2:6-20 -> 403:2-24',
328-
'2:6-20 -> 404:2-32',
329-
'2:6-20 -> 405:2-14',
330-
'2:6-20 -> 406:2-20',
331-
'2:6-20 -> 407:2-18',
332-
'2:6-20 -> 408:2-19',
333-
'2:6-20 -> 409:2-20',
334-
'2:6-20 -> 410:2-16',
335-
'2:6-20 -> 411:2-18',
336-
'2:6-20 -> 412:2-15',
337-
'2:6-20 -> 413:2-21',
338-
'2:6-20 -> 414:2-23',
339-
'2:6-20 -> 415:2-29',
340-
'2:6-20 -> 416:2-27',
341-
'2:6-20 -> 417:2-28',
342-
'2:6-20 -> 418:2-29',
343-
'2:6-20 -> 419:2-25',
344-
'2:6-20 -> 420:2-26',
345-
'2:6-20 -> 421:2-27',
346-
'2:6 -> 422:2',
347-
'2:20 -> 423:0',
348-
'2:6 -> 425:0',
349-
'2:6-20 -> 426:2-26',
297+
'2:6-20 -> 373:2-17',
298+
'2:6-20 -> 374:2-14',
299+
'2:20 -> 375:0',
300+
'2:6-20 -> 377:0-72',
301+
'2:6 -> 378:0',
302+
'2:6-20 -> 379:2-15',
303+
'2:20 -> 380:0',
304+
'2:6 -> 382:0',
305+
'2:6-20 -> 383:2-26',
306+
'2:6-20 -> 384:2-26',
307+
'2:6-20 -> 385:2-21',
308+
'2:6-20 -> 386:2-21',
309+
'2:6-20 -> 387:2-16',
310+
'2:6-20 -> 388:2-16',
311+
'2:6-20 -> 389:2-16',
312+
'2:6-20 -> 390:2-17',
313+
'2:6-20 -> 391:2-17',
314+
'2:6-20 -> 392:2-15',
315+
'2:6-20 -> 393:2-15',
316+
'2:6-20 -> 394:2-20',
317+
'2:6-20 -> 395:2-40',
318+
'2:6-20 -> 396:2-32',
319+
'2:6-20 -> 397:2-31',
320+
'2:6-20 -> 398:2-30',
321+
'2:6-20 -> 399:2-17',
322+
'2:6-20 -> 400:2-22',
323+
'2:6-20 -> 401:2-24',
324+
'2:6-20 -> 402:2-25',
325+
'2:6-20 -> 403:2-26',
326+
'2:6-20 -> 404:2-20',
327+
'2:6-20 -> 405:2-29',
328+
'2:6-20 -> 406:2-30',
329+
'2:6-20 -> 407:2-40',
330+
'2:6-20 -> 408:2-36',
331+
'2:6-20 -> 409:2-29',
332+
'2:6-20 -> 410:2-24',
333+
'2:6-20 -> 411:2-32',
334+
'2:6-20 -> 412:2-14',
335+
'2:6-20 -> 413:2-20',
336+
'2:6-20 -> 414:2-18',
337+
'2:6-20 -> 415:2-19',
338+
'2:6-20 -> 416:2-20',
339+
'2:6-20 -> 417:2-16',
340+
'2:6-20 -> 418:2-18',
341+
'2:6-20 -> 419:2-15',
342+
'2:6-20 -> 420:2-21',
343+
'2:6-20 -> 421:2-23',
344+
'2:6-20 -> 422:2-29',
345+
'2:6-20 -> 423:2-27',
346+
'2:6-20 -> 424:2-28',
347+
'2:6-20 -> 425:2-29',
348+
'2:6-20 -> 426:2-25',
350349
'2:6-20 -> 427:2-26',
351-
'2:6-20 -> 428:2-21',
352-
'2:6-20 -> 429:2-21',
353-
'2:6-20 -> 430:2-16',
354-
'2:6-20 -> 431:2-16',
355-
'2:6-20 -> 432:2-16',
356-
'2:6-20 -> 433:2-17',
357-
'2:6-20 -> 434:2-17',
358-
'2:6-20 -> 435:2-15',
359-
'2:6-20 -> 436:2-15',
360-
'2:6-20 -> 437:2-20',
361-
'2:6-20 -> 438:2-40',
362-
'2:6-20 -> 439:2-32',
363-
'2:6-20 -> 440:2-31',
364-
'2:6-20 -> 441:2-30',
365-
'2:6-20 -> 442:2-17',
366-
'2:6-20 -> 443:2-22',
367-
'2:6-20 -> 444:2-24',
368-
'2:6-20 -> 445:2-25',
369-
'2:6-20 -> 446:2-26',
370-
'2:6-20 -> 447:2-20',
371-
'2:6-20 -> 448:2-29',
372-
'2:6-20 -> 449:2-30',
373-
'2:6-20 -> 450:2-40',
374-
'2:6-20 -> 451:2-36',
375-
'2:6-20 -> 452:2-29',
376-
'2:6-20 -> 453:2-24',
377-
'2:6-20 -> 454:2-32',
378-
'2:6-20 -> 455:2-14',
379-
'2:6-20 -> 456:2-20',
380-
'2:6-20 -> 457:2-18',
381-
'2:6-20 -> 458:2-19',
382-
'2:6-20 -> 459:2-20',
383-
'2:6-20 -> 460:2-16',
384-
'2:6-20 -> 461:2-18',
385-
'2:6-20 -> 462:2-15',
386-
'2:6-20 -> 463:2-21',
387-
'2:6-20 -> 464:2-23',
388-
'2:6-20 -> 465:2-29',
389-
'2:6-20 -> 466:2-27',
390-
'2:6-20 -> 467:2-28',
391-
'2:6-20 -> 468:2-29',
392-
'2:6-20 -> 469:2-25',
393-
'2:6-20 -> 470:2-26',
394-
'2:6-20 -> 471:2-27',
395-
'2:6 -> 472:2',
396-
'2:20 -> 473:0',
350+
'2:6-20 -> 428:2-27',
351+
'2:6 -> 429:2',
352+
'2:20 -> 430:0',
353+
'2:6 -> 432:0',
354+
'2:6-20 -> 433:2-26',
355+
'2:6-20 -> 434:2-26',
356+
'2:6-20 -> 435:2-21',
357+
'2:6-20 -> 436:2-21',
358+
'2:6-20 -> 437:2-16',
359+
'2:6-20 -> 438:2-16',
360+
'2:6-20 -> 439:2-16',
361+
'2:6-20 -> 440:2-17',
362+
'2:6-20 -> 441:2-17',
363+
'2:6-20 -> 442:2-15',
364+
'2:6-20 -> 443:2-15',
365+
'2:6-20 -> 444:2-20',
366+
'2:6-20 -> 445:2-40',
367+
'2:6-20 -> 446:2-32',
368+
'2:6-20 -> 447:2-31',
369+
'2:6-20 -> 448:2-30',
370+
'2:6-20 -> 449:2-17',
371+
'2:6-20 -> 450:2-22',
372+
'2:6-20 -> 451:2-24',
373+
'2:6-20 -> 452:2-25',
374+
'2:6-20 -> 453:2-26',
375+
'2:6-20 -> 454:2-20',
376+
'2:6-20 -> 455:2-29',
377+
'2:6-20 -> 456:2-30',
378+
'2:6-20 -> 457:2-40',
379+
'2:6-20 -> 458:2-36',
380+
'2:6-20 -> 459:2-29',
381+
'2:6-20 -> 460:2-24',
382+
'2:6-20 -> 461:2-32',
383+
'2:6-20 -> 462:2-14',
384+
'2:6-20 -> 463:2-20',
385+
'2:6-20 -> 464:2-18',
386+
'2:6-20 -> 465:2-19',
387+
'2:6-20 -> 466:2-20',
388+
'2:6-20 -> 467:2-16',
389+
'2:6-20 -> 468:2-18',
390+
'2:6-20 -> 469:2-15',
391+
'2:6-20 -> 470:2-21',
392+
'2:6-20 -> 471:2-23',
393+
'2:6-20 -> 472:2-29',
394+
'2:6-20 -> 473:2-27',
395+
'2:6-20 -> 474:2-28',
396+
'2:6-20 -> 475:2-29',
397+
'2:6-20 -> 476:2-25',
398+
'2:6-20 -> 477:2-26',
399+
'2:6-20 -> 478:2-27',
400+
'2:6 -> 479:2',
401+
'2:20 -> 480:0',
397402
])
398403
})
399404

0 commit comments

Comments
 (0)