Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

font weight font-thin is different with 'OpenType specification' #1128

Closed
Quineone opened this issue Sep 18, 2019 · 3 comments · Fixed by #2333
Closed

font weight font-thin is different with 'OpenType specification' #1128

Quineone opened this issue Sep 18, 2019 · 3 comments · Fixed by #2333

Comments

@Quineone
Copy link

1.https://docs.microsoft.com/en-us/typography/opentype/spec/os2#usweightclass
2.https://developer.mozilla.org/en-US/docs/Web/CSS/font-weight#Common_weight_name_mapping

@hacknug
Copy link
Contributor

hacknug commented Sep 18, 2019

Also on the css-fonts spec: https://www.w3.org/TR/css-fonts-4/#font-weight-numeric-values

Only issue with this is it would be a breaking change and, since you can already configure the class names, I'm pretty sure it won't be prioritized at least until we can justify breaking things again (new major version, probably).

@adamwathan
Copy link
Member

Yeah I agree following those names would be better, but can't do anything about it until v2, and even then have to weigh the cost of that breaking change. Will tag this for v2 so we can circle back when we're closer to that time.

@adamwathan
Copy link
Member

Going to update this for 2.0, will keep this open until we introduce it behind a flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants