Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not throwing errors for nested circular dependency. #2293

Closed
jjjrmy opened this issue Sep 2, 2020 · 1 comment
Closed

Not throwing errors for nested circular dependency. #2293

jjjrmy opened this issue Sep 2, 2020 · 1 comment

Comments

@jjjrmy
Copy link

jjjrmy commented Sep 2, 2020

This throws a circular dependency error (which is expected).

.rounded-full {
    @apply rounded-full;
}

This doesn't throw an error but just gets stuck then crashes with some out of memory error.

.rounded-full {
    img { @apply rounded-full; }
}

I'm pretty sure the above code worked at one time, but probably doesn't anymore due to the recent changes.
But it should probably throw an error instead of just loading forever then crashing.

@jjjrmy jjjrmy changed the title Not Throwing: You cannot @apply the rounded-full utility here because it creates a circular dependency. Not throwing errors for nested circular dependency. Sep 3, 2020
@adamwathan
Copy link
Member

At its core this is the same underlying issue as #2192, so going to close this one but once we fix general support for nesting with @apply you will see a useful error here instead of the infinite loop crashing crap 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants