Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'inApp' field of 'File' and add description #4

Open
lgrahl opened this issue Jul 17, 2019 · 0 comments
Open

Rename 'inApp' field of 'File' and add description #4

lgrahl opened this issue Jul 17, 2019 · 0 comments

Comments

@lgrahl
Copy link
Contributor

lgrahl commented Jul 17, 2019

The File.inApp field is utterly confusingly named which is probably why it also lacks a description. 😅

Description: It controls whether a file message will be rendered according to the mime type within the app (if feasible). If false, the file should be treated as an attachment that will not be rendered.

It is currently unused in both app and web client. I'd propose to rename this to render.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant