Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translations loading is damn slow #364

Closed
KOLANICH opened this issue Dec 12, 2017 · 3 comments
Closed

Translations loading is damn slow #364

KOLANICH opened this issue Dec 12, 2017 · 3 comments

Comments

@KOLANICH
Copy link
Contributor

It slows down every program using plumbum a lot. I guess it should be disabled by default.

@henryiii
Copy link
Collaborator

Do you have an example so I can test and fix? Complex app or all (including simple) apps? How slow?

@KOLANICH
Copy link
Contributor Author

All apps. When I run an app using plumbum, there is a delay. If I hit ctrl+c during this delay, I get the KeyboardInterrupt exception, and this exception is likely to be in the code loading translations.

@henryiii
Copy link
Collaborator

Should be fixed in b7222f8. For me, the simple example went back down to 200 ms (like in 1.6.3) from 320 ms or so in 1.6.4 when using English.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants