-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to eslint flat config #99
Conversation
Bumps [eslint](https://github.com/eslint/eslint) from 8.57.0 to 9.1.1. - [Release notes](https://github.com/eslint/eslint/releases) - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md) - [Commits](eslint/eslint@v8.57.0...v9.1.1) --- updated-dependencies: - dependency-name: eslint dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
c0c6546
to
385ea6e
Compare
As @frothedoatmilk pointed out, I did in fact cause this to regress back to 8 due to dependency rules of some of the plugins. We can still merge this and wait for dependabot to reopen things once the other plugins get updated? |
Fine with me, we just gotta remember to do it when React gets bumped to 19. I'm not even really sure who to be mad at here. ESLint pushed this when...no one really wanted a brand new config style? But why is this config being restricted by React? I have many questions as to how we got here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm gonna make my OWN JS linter... with blackjack...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, I need to treat this as having ESLint 8.57, some stuff might be different because defaults are different!
'**/*.jsx', | ||
], | ||
rules: { | ||
...reactHooks.configs.recommended.rules, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...reactHooks.configs.recommended.rules, | |
...reactHooks.configs.recommended.rules, | |
'react-refresh/only-export-components': 'warn', |
Since we're no longer 'including', need to manually add this rule in
A newer version of eslint exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged. |
Man, the dependencies are really screwed up here. I'm going to ask dependabot to reopen with the present version of ESLint since |
OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting If you change your mind, just re-open this PR and I'll resolve any conflicts on it. |
Bumps eslint from 8.57.0 to 9.1.1.
Release notes
Sourced from eslint's releases.
... (truncated)
Changelog
Sourced from eslint's changelog.
... (truncated)
Commits
b4d2512
9.1.1ef36aa4
Build: changelog update for 9.1.1a26b402
fix: use@eslint/create-config
latest (#18373)b78d831
9.1.0e4d9c92
Build: changelog update for 9.1.0d9a2983
chore: upgrade@eslint/js
to v9.1.1 (#18367)03068f1
feat: Provide helpful error message for nullish configs (#18357)50d406d
chore: package.json update for@eslint/js
release8d18958
fix: Remove name from eslint/js packages (#18368)155c71c
chore: package.json update for@eslint/js
releaseYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)