Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type resolution for subpath exports when using moduleResolution: node #2486

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

connor-baer
Copy link
Contributor

TypeScript isn't able to resolve the types for subpath exports (e.g. react-map-gl/mapbox) when using moduleResolution: node in consuming apps (see this StackOverflow issue).

Adding typesVersions with * to target all TypeScript versions works around this limitation.

Copy link
Collaborator

@Pessimistress Pessimistress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Pessimistress Pessimistress merged commit 166138c into visgl:master Feb 7, 2025
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants