Skip to content

Commit e012f29

Browse files
authored
chore: remove stale TODOs (#17866)
1 parent 3dc23d9 commit e012f29

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

packages/plugin-legacy/src/index.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -545,7 +545,7 @@ function viteLegacyPlugin(options: Options = {}): Plugin[] {
545545
configFile: false,
546546
compact: !!config.build.minify,
547547
sourceMaps,
548-
inputSourceMap: undefined, // sourceMaps ? chunk.map : undefined, `.map` TODO: moved to OutputChunk?
548+
inputSourceMap: undefined,
549549
presets: [
550550
// forcing our plugin to run before preset-env by wrapping it in a
551551
// preset so we can catch the injected import statements...

packages/vite/src/node/plugins/asset.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -388,7 +388,7 @@ async function fileToBuiltUrl(
388388
})
389389
generatedAssets.get(config)!.set(referenceId, { originalFileName })
390390

391-
url = `__VITE_ASSET__${referenceId}__${postfix ? `$_${postfix}__` : ``}` // TODO_BASE
391+
url = `__VITE_ASSET__${referenceId}__${postfix ? `$_${postfix}__` : ``}`
392392
}
393393

394394
cache.set(id, url)

packages/vite/src/node/ssr/ssrManifestPlugin.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ import {
1919
export function ssrManifestPlugin(config: ResolvedConfig): Plugin {
2020
// module id => preload assets mapping
2121
const ssrManifest: Record<string, string[]> = {}
22-
const base = config.base // TODO:base
22+
const base = config.base
2323

2424
return {
2525
name: 'vite:ssr-manifest',
@@ -78,7 +78,7 @@ export function ssrManifestPlugin(config: ResolvedConfig): Plugin {
7878
const chunk = bundle[filename] as OutputChunk | undefined
7979
if (chunk) {
8080
chunk.viteMetadata!.importedCss.forEach((file) => {
81-
deps.push(joinUrlSegments(base, file)) // TODO:base
81+
deps.push(joinUrlSegments(base, file))
8282
})
8383
chunk.imports.forEach(addDeps)
8484
}

0 commit comments

Comments
 (0)