Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DevTools request #1496

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Fix DevTools request #1496

merged 2 commits into from
Jun 3, 2019

Conversation

juankaromo
Copy link
Contributor

Hi team,

PUT and POST are the methods that allow body in requests, instead of GET and DELETE that only accept query string.

Regards

@juankaromo juankaromo added the type/bug Bug issue label May 29, 2019
@juankaromo juankaromo requested a review from jesusgn90 May 29, 2019 13:03
@juankaromo juankaromo self-assigned this May 29, 2019
@jesusgn90
Copy link
Contributor

jesusgn90 commented Jun 3, 2019 •
edited by juankaromo
Loading

Please make the next tests before merging this PR:

  • GET
    • Body parameters
    • Inline parameters
    • No parameters
    • Mixing parameters + inline (inline has precedence)
  • PUT
    • Body parameters
    • Inline parameters
    • No parameters
  • POST
    • Body parameters
    • Inline parameters
    • Mixing parameters + inline (inline has precedence)
  • DELETE
    • Body parameters
    • Inline parameters
    • No parameters
    • Mixing parameters + inline (inline has precedence)

@jesusgn90 jesusgn90 changed the title Change GET for PUT in body request maker Fix DevTools request Jun 3, 2019
@juankaromo
Copy link
Contributor Author

juankaromo commented Jun 3, 2019 •
edited
Loading

Tests results

GET POST PUT DELETE
NO PARAMS OK -- OK OK
INLINE PARAMS OK OK OK OK
JSON PARAMS OK OK OK OK
INLINE + JSON PARAMS OK OK OK OK

All tests have passed successfully.

  • The POST method without PARAMS has not been tested because it does not make sense.

@jesusgn90 jesusgn90 merged commit 993fe80 into 3.9-7.1 Jun 3, 2019
@jesusgn90 jesusgn90 deleted the fix-dev-tools-querys branch June 3, 2019 11:41
jesusgn90 pushed a commit that referenced this pull request Jun 6, 2019
Fix DevTools request (#1496)
50b15be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jesusgn90 jesusgn90 Awaiting requested review from jesusgn90

Assignees

@juankaromo juankaromo

Labels
type/bug Bug issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juankaromo @jesusgn90