Ran some standard Androidstudio checks and resolved some warning

Author: ironjan

src/main/java/io/yippie/iupb/app/MainActivity.java

@@ -5,14 +5,13 @@
 import android.content.res.*;
 import android.net.*;
 import android.os.*;
-import android.support.v4.app.FragmentTransaction;
+import android.support.v4.app.*;
 import android.util.*;
 import android.view.*;
 import android.webkit.*;
 import android.widget.*;
 
 import com.actionbarsherlock.app.*;
-import com.actionbarsherlock.app.ActionBar;
 import com.actionbarsherlock.app.ActionBar.*;
 import com.actionbarsherlock.view.Menu;
 import com.actionbarsherlock.view.MenuItem;
@@ -29,13 +28,13 @@
  * TODO doc
  */
 @EActivity(R.layout.activity_main)
-@SuppressLint("SetJavaScriptEnabled")
+@SuppressLint({"Registered"})
 public class MainActivity extends SherlockActivity implements
         TabListener, OnNavigationListener, IUpbWebViewCallback {
 
     private static final String ASSETS_LOADING_HTML = "file:///android_asset/loading.html";
     private static final String ASSETS_OFFLINE_HTML = "file:///android_asset/offline.html";
-    public final static int FILECHOOSER_REQUEST_CODE = 1;
+    public final static int FILE_CHOOSER_REQUEST_CODE = 1;
     private final String TAG = getClass().getSimpleName();
 
     /**
@@ -78,10 +77,12 @@ public void onCreate(Bundle savedInstanceState) {
     void afterViews() {
         mCurrentUrl = generateURL(getString(R.string.actionbar_restaurants_url));
         mMainWebView.setCallback(this);
-        // ASSETS_LOADING_HTML is loaded to show that something's happening
+        // ASSETS_LOADING_HTML is loaded to show that something is happening
         mMainWebView.loadUrl(ASSETS_LOADING_HTML);
         mMainWebView.loadUrl(mCurrentUrl);
 
+        setSupportProgressBarVisibility(true);
+        setSupportProgressBarIndeterminateVisibility(true);
         initActionBar();
         initNavigation();
     }
@@ -91,8 +92,6 @@ private void initActionBar() {
         actionBar.setHomeButtonEnabled(true);
         actionBar.setDisplayShowHomeEnabled(true);
         actionBar.setDisplayShowTitleEnabled(false);
-        setSupportProgressBarVisibility(true);
-        setSupportProgressBarIndeterminateVisibility(true);
     }
 
     private void initNavigation() {
@@ -122,7 +121,7 @@ public void onRestoreInstanceState(Bundle savedInstanceState) {
     @Override
     protected void onActivityResult(int requestCode, int resultCode,
                                     Intent intent) {
-        if (requestCode == FILECHOOSER_REQUEST_CODE) {
+        if (requestCode == FILE_CHOOSER_REQUEST_CODE) {
             if (null == mUploadMessage)
                 return;
             Uri result = intent == null || resultCode != RESULT_OK ? null
@@ -148,17 +147,6 @@ public void onConfigurationChanged(Configuration newConfig) {
             invalidateOptionsMenu();
     }
 
-    protected synchronized void removeOfflineNotice() {
-        if (offlineMode) {
-            offlineMode = false;
-            if (mMainWebView.canGoBack())
-                mMainWebView.goBack();
-            else
-                loadWebView(generateURL(getString(R.string.actionbar_restaurants_url)));
-            mMainWebView.clearHistory();
-        }
-    }
-
     @Override
     public synchronized void displayOfflineNotice() {
         if (!offlineMode) {
@@ -214,7 +202,7 @@ private void loadHomeScreen() {
     }
 
     /**
-     * loads a specific view for the current webview
+     * loads a specific view for the current web view
      */
     private void loadWebView(String url) {
         mCurrentUrl = url;

src/main/java/io/yippie/iupb/app/webview/IUpbWebChromeClient.java

@@ -12,6 +12,7 @@
 
 /**
  * TODO doc
+ * TODO why are there methods like openFileChooser? they are not used
  */
 @EBean
 public class IUpbWebChromeClient extends WebChromeClient {
@@ -34,7 +35,7 @@ public void onProgressChanged(WebView view, int progress) {
     }
 
     // For Android 3.0 - 4.0 (enables file upload)
-    public void openFileChooser(ValueCallback<Uri> uploadMsg, String acceptType) {
+    void openFileChooser(ValueCallback<Uri> uploadMsg, String acceptType) {
         Log.i(TAG, "Upload started");
         triggerUploadIntent(uploadMsg);
     }
@@ -45,7 +46,7 @@ private void triggerUploadIntent(
         Intent i = new Intent(Intent.ACTION_GET_CONTENT);
         i.addCategory(Intent.CATEGORY_OPENABLE);
         i.setType("image/*");
-        mActivity.startActivityForResult(Intent.createChooser(i, "Image Browser"), MainActivity.FILECHOOSER_REQUEST_CODE);
+        mActivity.startActivityForResult(Intent.createChooser(i, "Image Browser"), MainActivity.FILE_CHOOSER_REQUEST_CODE);
     }
 
     // For Android 4.1+ (enables file upload)
@@ -59,7 +60,7 @@ public void openFileChooser(ValueCallback<Uri> uploadMsg) {
         openFileChooser(uploadMsg, "");
     }
 
-    public static final IUpbWebChromeClientCallback sDUMMY_CALLBACK = new IUpbWebChromeClientCallback() {
+    private static final IUpbWebChromeClientCallback sDUMMY_CALLBACK = new IUpbWebChromeClientCallback() {
         @Override
         public void setProgressValue(int progress) {
             // dummy

src/main/java/io/yippie/iupb/app/webview/IUpbWebView.java

@@ -1,5 +1,6 @@
 package io.yippie.iupb.app.webview;
 
+import android.annotation.*;
 import android.content.*;
 import android.net.*;
 import android.util.*;
@@ -16,12 +17,13 @@ public class IUpbWebView extends WebView implements IUpbWebChromeClientCallback,
     IUpbWebViewClient webViewClient;
     @Bean
     IUpbWebChromeClient webChromeClient;
-    IUpbWebViewCallback mCallback = sDUMMY_CALLBACK;
+    private IUpbWebViewCallback mCallback = sDUMMY_CALLBACK;
 
     public IUpbWebView(Context context, AttributeSet attrs) {
         super(context, attrs);
     }
 
+    @SuppressLint("SetJavaScriptEnabled")
     @AfterInject
     void init() {
         webViewClient.setIUpbWebClientCallback(this);
@@ -57,7 +59,7 @@ public void setCallback(IUpbWebViewCallback callback) {
         this.mCallback = callback;
     }
 
-    public static final IUpbWebViewCallback sDUMMY_CALLBACK = new IUpbWebViewCallback() {
+    private static final IUpbWebViewCallback sDUMMY_CALLBACK = new IUpbWebViewCallback() {
         @Override
         public void setProgressValue(int progress) {
             // dummy

src/main/java/io/yippie/iupb/app/webview/IUpbWebViewClient.java

@@ -10,8 +10,8 @@
 import io.yippie.iupb.app.*;
 
 /**
-* TODO doc
-*/
+ * TODO doc
+ */
 @EBean
 public class IUpbWebViewClient extends WebViewClient {
     @RootContext
@@ -54,7 +54,7 @@ public boolean shouldOverrideUrlLoading(WebView view, String url) {
         }
     }
 
-    public static final IUpbWebClientCallback sDUMMY_CALLBACK = new IUpbWebClientCallback() {
+    private static final IUpbWebClientCallback sDUMMY_CALLBACK = new IUpbWebClientCallback() {
         @Override
         public void displayOfflineNotice() {
             // dummy