Skip to content
This repository was archived by the owner on May 16, 2018. It is now read-only.

Session Validators throw 'general' Session Exception during Session start #547

Closed
holtkamp opened this issue Apr 3, 2015 · 1 comment
Closed

Comments

@holtkamp
Copy link
Contributor

holtkamp commented Apr 3, 2015

Session Validators (like Zend_Session_Validator_HttpUserAgent), provide an easy and extendable mechanism to validate sessions during startup.

However, when validation fails during session startup, a general Zend_Session_Exception is thrown. The same Zend_Session_Exception can be thrown due to other causes, for example:

How can one be sure that an Exception caught during session start was caused by a certain Validator that fails? Would it not be better to have:

  • either a general Exception class used by all Validators: Zend_Session_Validator_Exception, this would be better than nothing, but when using multiple Exceptions this also might become to 'general'
  • or a per-validator specific Exception, for example: Zend_Session_Validator_HttpUserAgent_Exception

Maybe I am missing something, but in case one of the aforementioned solutions is regarded viable, I can come up with a PR, starting with the first suggestion which seems quite straight forward.

@froschdesign
Copy link
Member

Fixed with #548

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants