Downgrade AWS SDK to 2.15.79 #18638
Downgrade AWS SDK to 2.15.79 #18638
Conversation
|
@dbw9580 can this PR be merged into |
| <!-- Pin this version to make the library compatible with netty 4.1.52.Final version --> | ||
| <awssdk.version>2.16.104</awssdk.version> | ||
| <awssdk.version>2.15.79</awssdk.version> |
There was a problem hiding this comment.
interestingly enough, both this comment and version string was added in the same PR: https://github.com/Alluxio/alluxio/pull/17242/files#diff-9c5fb3d1b7e3b0f54bc5c4182965c4fe1f9023d449017cece3005d3f90e8e4d8R128-R129
have you consulted with @elega on how the original version string was obtained?
There was a problem hiding this comment.
The original version was the higest version we could use that made the code build. Any higher netty version will break the alluxio build because it has interface changes. Downgrading the version is okay and does not make any issue, giving that none actually uses the feature.
can also reverse cherry pick back to master-2.x. just want to make sure both branches have the same change |
Master-2.x branch uses another different netty version 4.1.87-Final, which is higher than what aws sdk depends on. Not sure if the issue exists there. If the issue exists in master branch, the fix should be to upgrade aws sdk to a version that depends on a higher version of netty that matches 4.1.87. |
ok let's move this fix along for now |
|
The best way to fix such conflict issue is to shade the dependencies and depend on the shaded ones. If we are to fix this in the master branch I think we should do that. |
|
alluxio-bot, merge this please |
|
merge failed: |
|
alluxio-bot, merge this please |
What changes are proposed in this pull request?
Downgrade the version of AWS SDK to 2.15.79
Why are the changes needed?
The current AWS SDK version 2.16.104 depends on Netty 4.1.63-Final, and Alluxio depends on Netty 4.1.52-Final. There is a conflict between the two versions that causes Netty's native epoll library to fail to be loaded. Consequently, the data server on a worker cannot be started on a domain socket which requires epoll, and thus short circuit read cannot be enabled in a Kubernetes deployment.
Does this PR introduce any user facing changes?
No.